[PATCH] D27565: [libcxx] Alternative fix for compressed pair

2016-12-07 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. Grr... OK so this is currently ABI breaking because it re-arranges the layout of `__compressed_pair` when `T2` is empty but `T1` is not. I might be able to work around this with some metaprogramming. https://reviews.llvm.org/D27565 ___

[PATCH] D27565: [libcxx] Alternative fix for compressed pair

2016-12-07 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF updated this revision to Diff 80715. EricWF added a comment. Remove ever more dead code. https://reviews.llvm.org/D27565 Files: include/__hash_table include/memory include/string test/std/utilities/memory/unique.ptr/unique.ptr.runtime/unique.ptr.runtime.ctor/default01.fail.cpp

[PATCH] D27565: [libcxx] Alternative fix for compressed pair

2016-12-07 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF created this revision. EricWF added a reviewer: mclow.lists. EricWF added a subscriber: cfe-commits. I would rather have this fix than https://reviews.llvm.org/D27564, but I'm not yet sure it isn't ABI breaking. https://reviews.llvm.org/D27565 Files: include/__hash_table include/mem