This revision was automatically updated to reflect the committed changes.
Closed by commit rL289094: [DebugInfo] Add support for __fp16, float, and
double constants. (authored by dgross).
Changed prior to commit:
https://reviews.llvm.org/D27549?vs=80683&id=80806#toc
Repository:
rL LLVM
http
probinson accepted this revision.
probinson added a reviewer: probinson.
probinson added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: lib/CodeGen/CGDebugInfo.cpp:3765
+InitExpr =
+
DBuilder.createConstantValueExpression(Init.getFloat
dgross added inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:3765
+InitExpr =
+
DBuilder.createConstantValueExpression(Init.getFloat().bitcastToAPInt().getZExtValue());
GV.reset(DBuilder.createGlobalVariable(
probinson wrote:
> This line e
dgross updated this revision to Diff 80683.
dgross added a comment.
Incorporate code review feedback.
- Reformat source.
- Make test pattern more general.
https://reviews.llvm.org/D27549
Files:
lib/CodeGen/CGDebugInfo.cpp
test/CodeGen/debug-info-static-const-fp.c
Index: test/CodeGen/debu
probinson added subscribers: cfe-commits, probinson.
probinson added a comment.
Hi David!
As this is a Clang patch, you should subscribe cfe-commits rather than
llvm-commits. I've done that for you.
See also inline comments.
Comment at: lib/CodeGen/CGDebugInfo.cpp:3765
+I
