bruno added a comment.
> Does this cause us to deserialize the SLocEntry for every FileID referenced
> by a RawComment? That would seem pretty bad.
I don't recall because It's been a while, but I'm gonna take a look and get
back to you. Thanks
https://reviews.llvm.org/D27546
__
rsmith added inline comments.
Comment at: lib/Serialization/ASTReader.cpp:8487
+std::sort(Comments.begin(), Comments.end(),
+ BeforeThanCompare(SourceMgr));
Context.Comments.addDeserializedComments(Comments);
Does this cause us to deserializ
bruno closed this revision.
bruno added a comment.
Done in r290134
https://reviews.llvm.org/D27546
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
manmanren accepted this revision.
manmanren added a comment.
This revision is now accepted and ready to land.
LGTM.
Manman
https://reviews.llvm.org/D27546
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
bruno added a comment.
Ping!
https://reviews.llvm.org/D27546
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno created this revision.
bruno added reviewers: manmanren, akyrtzi, rsmith.
bruno added a subscriber: cfe-commits.
`RawComments` are sorted by comparing underlying `SourceLocation`'s. This is
done by comparing `FileID` and `Offset`; when the `FileID` is the same it means
the locations are wit
