[PATCH] D27523: [change-namespace] don't fix using shadow decls in classes.

2016-12-07 Thread Eric Liu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL288919: [change-namespace] don't fix using shadow decls in classes. (authored by ioeric). Changed prior to commit: https://reviews.llvm.org/D27523?vs=80613&id=80615#toc Repository: rL LLVM https://r

[PATCH] D27523: [change-namespace] don't fix using shadow decls in classes.

2016-12-07 Thread Eric Liu via Phabricator via cfe-commits
ioeric updated this revision to Diff 80613. ioeric added a comment. - address review comment. https://reviews.llvm.org/D27523 Files: change-namespace/ChangeNamespace.cpp unittests/change-namespace/ChangeNamespaceTests.cpp Index: unittests/change-namespace/ChangeNamespaceTests.cpp =

[PATCH] D27523: [change-namespace] don't fix using shadow decls in classes.

2016-12-07 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer accepted this revision. bkramer added inline comments. This revision is now accepted and ready to land. Comment at: change-namespace/ChangeNamespace.cpp:331 + // Using shadow declarations in classes always refers to base class, which + // does not need to be qualified s

[PATCH] D27523: [change-namespace] don't fix using shadow decls in classes.

2016-12-07 Thread Eric Liu via Phabricator via cfe-commits
ioeric created this revision. ioeric added a reviewer: bkramer. ioeric added a subscriber: cfe-commits. Using shadow declarations in classes always refers to base class, which does not need to be fixed/qualified since it can be inferred from inheritance. https://reviews.llvm.org/D27523 Files: