This revision was automatically updated to reflect the committed changes.
Closed by commit rL289535: [OpenCL] Enable unroll hint for OpenCL 1.x.
(authored by echuraev).
Changed prior to commit:
https://reviews.llvm.org/D27453?vs=80547&id=81223#toc
Repository:
rL LLVM
https://reviews.llvm.or
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks!
https://reviews.llvm.org/D27453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
echuraev updated this revision to Diff 80547.
echuraev marked an inline comment as done.
https://reviews.llvm.org/D27453
Files:
lib/Sema/SemaStmtAttr.cpp
test/CodeGenOpenCL/unroll-hint.cl
test/SemaOpenCL/unroll-hint.cl
Index: test/SemaOpenCL/unroll-hint.cl
Anastasia added inline comments.
Comment at: lib/Sema/SemaStmtAttr.cpp:232
- if (S.getLangOpts().OpenCLVersion < 200) {
-S.Diag(A.getLoc(), diag::err_attribute_requires_opencl_version)
The comment above refers to v2.0, could we update it reflecting the fac
echuraev created this revision.
echuraev added a reviewer: Anastasia.
echuraev added subscribers: bader, cfe-commits, yaxunl.
Although the feature was introduced only in OpenCL C v2.0 spec., it's useful
for OpenCL 1.x too and doesn't require HW support.
https://reviews.llvm.org/D27453
Files:
