[PATCH] D27410: Always issue vtables when generating coverage instrumentation

FlameTop abandoned this revision. FlameTop added a comment. I must apologise to you all. The problem was reported in our out-of-tree version of the compiler and I must have hit finger problems when I confirmed it in tree. Repeating the test I can no longer reproduce the fault with the 3.9.0 pub

[PATCH] D27410: Always issue vtables when generating coverage instrumentation

vsk added inline comments. Comment at: llvm/tools/clang/test/CodeGenCXX/vtable-coverage-gen.cpp:3 +// RUN: FileCheck %s < %t +// CHECK: @_ZTV8Category = linkonce_odr unnamed_addr constant {{.*}}, comdat, + vsk wrote: > ahatanak wrote: > > I'm not sure I understo

[PATCH] D27410: Always issue vtables when generating coverage instrumentation

vsk added inline comments. Comment at: llvm/tools/clang/test/CodeGenCXX/vtable-coverage-gen.cpp:3 +// RUN: FileCheck %s < %t +// CHECK: @_ZTV8Category = linkonce_odr unnamed_addr constant {{.*}}, comdat, + ahatanak wrote: > I'm not sure I understood the purpose

[PATCH] D27410: Always issue vtables when generating coverage instrumentation

ahatanak added inline comments. Comment at: llvm/tools/clang/test/CodeGenCXX/vtable-coverage-gen.cpp:3 +// RUN: FileCheck %s < %t +// CHECK: @_ZTV8Category = linkonce_odr unnamed_addr constant {{.*}}, comdat, + I'm not sure I understood the purpose of this test,

[PATCH] D27410: Always issue vtables when generating coverage instrumentation

FlameTop created this revision. FlameTop added a reviewer: rsmith. FlameTop added a subscriber: cfe-commits. The provided test shows a case where enabling coverage instrumentation causes a link error during building. Normally the all the base class items (vtable, ctors and dtors) would be remove