This revision was automatically updated to reflect the committed changes.
Closed by commit rL288917: [analyzer] Remove an unused enum value in
RetainCountChecker. (authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D27408?vs=80431&id=80608#toc
Repository:
rL LLVM
http
zaks.anna added a comment.
LGTM.
https://reviews.llvm.org/D27408
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
NoQ updated this revision to Diff 80431.
NoQ added a comment.
Remove OwnedAllocatedSymbol instead.
https://reviews.llvm.org/D27408
Files:
include/clang/StaticAnalyzer/Checkers/ObjCRetainCount.h
lib/StaticAnalyzer/Checkers/RetainCountChecker.cpp
Index: lib/StaticAnalyzer/Checkers/RetainCoun
dcoughlin added inline comments.
Comment at: include/clang/StaticAnalyzer/Checkers/ObjCRetainCount.h:179
- static RetEffect MakeOwned(ObjKind o, bool isAllocated = false) {
-return RetEffect(isAllocated ? OwnedAllocatedSymbol : OwnedSymbol, o);
+ static RetEffect MakeOw
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
I suspect allocated owned means that the analyzer saw the allocation site.
Removing dead code is great! Thanks. This looks good to me other than the name
of the method that I commented a
NoQ created this revision.
NoQ added reviewers: zaks.anna, dcoughlin.
NoQ added a subscriber: cfe-commits.
`OwnedSymbol` is not used anywhere; `OwnedAllocatedSymbol` is used instead. I
couldn't grasp the intended difference between the two, maybe we should remove
it?
https://reviews.llvm.org/D
