MyDeveloperDay commandeered this revision.
MyDeveloperDay edited reviewers, added: lhchavez; removed: MyDeveloperDay.
MyDeveloperDay added a comment.
This revision is no needed, the test will pass without any additional code
changes
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D27377/ne
MyDeveloperDay added a comment.
While reviewing old revisions either not landed or unreviewed I stumbled across
this accepted review. Looking at the current code I think its not needed
anymore. Perhaps if we merge your test in with the current trunk we can
determine if this is still needed
C
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good. Thank you!
https://reviews.llvm.org/D27377
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
lhchavez marked 3 inline comments as done.
lhchavez added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:870
+}
+// 'default' can appear in a Java 8 declaration. Parse it as such.
+break;
djasper wrote:
> Is there a test case that hit
lhchavez updated this revision to Diff 81280.
lhchavez added a comment.
Addressed feedback
https://reviews.llvm.org/D27377
Files:
lib/Format/UnwrappedLineParser.cpp
unittests/Format/FormatTestJava.cpp
Index: unittests/Format/FormatTestJava.cpp
=
djasper added inline comments.
Comment at: lib/Format/UnwrappedLineParser.cpp:297
case tok::kw_default:
+ if (Style.Language != FormatStyle::LK_Java || !Line->MustBeDeclaration) {
+if (!SwitchLabelEncountered &&
Same as below.
lodato resigned from this revision.
lodato removed a reviewer: lodato.
lodato added a comment.
I know nothing about the C++ code. I only know the git-clang-format script.
https://reviews.llvm.org/D27377
___
cfe-commits mailing list
cfe-commits@lists
lhchavez added a comment.
Gentle ping?
https://reviews.llvm.org/D27377
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
srhines added a comment.
Looks good, but I I want to make sure that someone else more familiar with this
is ok with it too. Thanks.
https://reviews.llvm.org/D27377
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
lhchavez created this revision.
lhchavez added a reviewer: djasper.
lhchavez added subscribers: srhines, cfe-commits.
Herald added a subscriber: klimek.
Java 8 introduced the use of using the 'default' keyword as modifier in
interface method declarations[1]. Previously it was being parsed as
being
10 matches
Mail list logo
