This revision was automatically updated to reflect the committed changes.
Closed by commit rL288379: Protect optional test under libcpp-no-exceptions
(authored by rogfer01).
Changed prior to commit:
https://reviews.llvm.org/D27254?vs=79765&id=79932#toc
Repository:
rL LLVM
https://reviews.ll
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
Looks good now - thanks.
https://reviews.llvm.org/D27254
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/
rogfer01 updated this revision to Diff 79765.
rogfer01 added a comment.
Protect the right set of tests.
https://reviews.llvm.org/D27254
Files:
test/std/experimental/optional/optional.specalg/swap.pass.cpp
Index: test/std/experimental/optional/optional.specalg/swap.pass.cpp
=
rogfer01 added inline comments.
Comment at: test/std/experimental/optional/optional.specalg/swap.pass.cpp:225
}
+#ifndef TEST_HAS_NO_EXCEPTIONS
{
mclow.lists wrote:
> Why is this here, and not before line L#236?
Yep, I'm wrong here. Probably a fallout o
mclow.lists added inline comments.
Comment at: test/std/experimental/optional/optional.specalg/swap.pass.cpp:225
}
+#ifndef TEST_HAS_NO_EXCEPTIONS
{
Why is this here, and not before line L#236?
https://reviews.llvm.org/D27254
__
rogfer01 created this revision.
rogfer01 added reviewers: mclow.lists, EricWF, rmaprath.
rogfer01 added a subscriber: cfe-commits.
Replace throw with TEST_THROW and skip tests that throw exceptions
https://reviews.llvm.org/D27254
Files:
test/std/experimental/optional/optional.specalg/swap.pas
