This revision was automatically updated to reflect the committed changes.
Closed by commit rL291082: Add AVR target and toolchain to Clang (authored by
dylanmckay).
Changed prior to commit:
https://reviews.llvm.org/D27123?vs=80721&id=83191#toc
Repository:
rL LLVM
https://reviews.llvm.org/D2
dylanmckay added a comment.
Signed off by Jonathan Roelofs via cfe-commits
https://reviews.llvm.org/D27123
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
I've just raised a bug here
https://llvm.org/bugs/show_bug.cgi?id=31530
> What's necessary for sign-off? Should I ping the reviewer (Richard Smith)
again?
I think so long as Richard or someone else who actively works on Clang
signs off. Perhaps somebody else is keen to review?
On the other hand
Did you get the BugZilla account sorted Senthil?
On Thu, Dec 22, 2016 at 10:47 AM, Nico Weber wrote:
> On Wed, Dec 21, 2016 at 6:42 AM, Senthil Kumar Selvaraj via Phabricator
> via cfe-commits wrote:
>
>> saaadhu added a comment.
>>
>> Would someone with a llvm bugzilla account please file the
On 1/4/17 2:52 AM, Dylan McKay wrote:
I've just raised a bug here
https://llvm.org/bugs/show_bug.cgi?id=31530
> What's necessary for sign-off? Should I ping the reviewer (Richard
Smith) again?
I think so long as Richard or someone else who actively works on Clang
signs off. Perhaps somebo
Dylan McKay writes:
> Did you get the BugZilla account sorted Senthil?
Nope, direct email also didn't help. Can you please file a bug with
Title:
UINT16_TYPE and INT16_TYPE are defined as short instead of int for AVR
Description:
UINT16_TYPE and INT16_TYPE are implicitly defined by the pr
On Wed, Dec 21, 2016 at 6:42 AM, Senthil Kumar Selvaraj via Phabricator via
cfe-commits wrote:
> saaadhu added a comment.
>
> Would someone with a llvm bugzilla account please file the PR for me? New
> user registration is disabled, and I've been waiting for
> llvm-ad...@lists.llvm.org to respond
I'm happy to file a bug if you give me a description
> Would one of the reviewers commit the patch for me?
I'm happy to commit it, so long as somebody else signs off on it.
On Thu, Dec 22, 2016 at 12:42 AM, Senthil Kumar Selvaraj via Phabricator <
revi...@reviews.llvm.org> wrote:
> saaadhu adde
saaadhu added a comment.
Would someone with a llvm bugzilla account please file the PR for me? New user
registration is disabled, and I've been waiting for llvm-ad...@lists.llvm.org
to respond for nearly a week now.
And how should I proceed after that? Would one of the reviewers commit the
pat
jroelofs added a comment.
In https://reviews.llvm.org/D27123#617118, @jroelofs wrote:
> In https://reviews.llvm.org/D27123#616887, @saaadhu wrote:
>
> > Make defines for CHAR16_TYPE, {U,}INT_{LEAST,FAST}16_TYPE use int instead
> > of short.
> >
> > {U,}INT16_TYPE still gets defined as short thou
rengolin added a comment.
In https://reviews.llvm.org/D27123#617118, @jroelofs wrote:
> In https://reviews.llvm.org/D27123#616887, @saaadhu wrote:
>
> > Make defines for CHAR16_TYPE, {U,}INT_{LEAST,FAST}16_TYPE use int instead
> > of short.
> >
> > {U,}INT16_TYPE still gets defined as short thou
dylanmckay added inline comments.
Comment at: lib/Basic/Targets.cpp:8543
+ case llvm::Triple::avr:
+return new AVRTargetInfo(Triple, Opts);
case llvm::Triple::bpfeb:
If we build clang without `LLVM_EXPERIMENTAL_TARGETS_TO_BUILD=AVR`, how will
this work?
jroelofs added a subscriber: rengolin.
jroelofs added a comment.
In https://reviews.llvm.org/D27123#616887, @saaadhu wrote:
> Make defines for CHAR16_TYPE, {U,}INT_{LEAST,FAST}16_TYPE use int instead of
> short.
>
> {U,}INT16_TYPE still gets defined as short though -
> lib/Frontend/InitPreproce
saaadhu updated this revision to Diff 80721.
saaadhu added a comment.
Make defines for CHAR16_TYPE, {U,}INT_{LEAST,FAST}16_TYPE use int instead of
short.
{U,}INT16_TYPE still gets defined as short though -
lib/Frontend/InitPreprocessor.cpp::DefineExactWidthIntType does not use
TargetInfo::getI
jroelofs added a comment.
In https://reviews.llvm.org/D27123#615738, @saaadhu wrote:
> Thanks, setting DoubleFormat and LongDoubleFormat fixed the __DBL_ and
> __LDBL_ differences. Also, setting SigAtomicType fixed the __SIG_ATOMIC_
> differences as well. I've added those defines to the test. U
saaadhu updated this revision to Diff 80575.
saaadhu added a comment.
Thanks, setting DoubleFormat and LongDoubleFormat fixed the __DBL_ and __LDBL_
differences. Also, setting SigAtomicType fixed the __SIG_ATOMIC_ differences as
well. I've added those defines to the test. Unrelated, but I also r
jroelofs added a comment.
In https://reviews.llvm.org/D27123#614313, @saaadhu wrote:
> Add testcases to test/Preprocessor/init.c
Awesome, thanks!
> Correct types for WChar and WInt
>
> The ABI is documented in the avr-gcc wiki (https://gcc.gnu.org/wiki/avr-gcc)
> I took the output of a trunk
17 matches
Mail list logo
