[PATCH] D27066: Fix crash with unsupported architectures in Linux/Gnu target triples.

2016-12-01 Thread Florian Hahn via Phabricator via cfe-commits
fhahn updated this revision to Diff 79883. fhahn added a comment. Herald added a subscriber: mehdi_amini. Addressed @joerg's comment. https://reviews.llvm.org/D27066 Files: lib/Driver/Tools.cpp test/Driver/unsupported-target-arch.c Index: test/Driver/unsupported-target-arch.c

[PATCH] D27066: Fix crash with unsupported architectures in Linux/Gnu target triples.

2016-11-30 Thread Joerg Sonnenberger via Phabricator via cfe-commits
joerg accepted this revision. joerg added a reviewer: joerg. joerg added a comment. LGTM with a small cleanup. Comment at: lib/Driver/Tools.cpp:10018 + const char *LDMOption = getLDMOption(ToolChain.getTriple(), Args); + if (!LDMOption) { +D.Diag(diag::err_target_unknown_

[PATCH] D27066: Fix crash with unsupported architectures in Linux/Gnu target triples.

2016-11-30 Thread Eric Christopher via Phabricator via cfe-commits
echristo accepted this revision. echristo added a comment. This revision is now accepted and ready to land. LGTM. Thanks! https://reviews.llvm.org/D27066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D27066: Fix crash with unsupported architectures in Linux/Gnu target triples.

2016-11-30 Thread Florian Hahn via Phabricator via cfe-commits
fhahn added a comment. Ping. https://reviews.llvm.org/D27066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27066: Fix crash with unsupported architectures in Linux/Gnu target triples.

2016-11-23 Thread Florian Hahn via cfe-commits
fhahn created this revision. fhahn added a reviewer: rafael. fhahn added a subscriber: cfe-commits. Herald added a subscriber: dschuff. This patch adds a check and an error message to gnutools::Linker::ConstructJob in case the architecture is not supported. For most other operating systems, the