This revision was automatically updated to reflect the committed changes.
Closed by commit rL287863: [clang-move] Enable dump all declarations in old
header. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D27059?vs=79194&id=79201#toc
Repository:
rL LLVM
https://revi
ioeric added a comment.
LG with a nit.
Comment at: clang-move/tool/ClangMoveMain.cpp:155
+ // Don't print trailing "," at the end of last element.
+ if (DeclPair != *(--Declarations.end()))
+llvm::outs() << ",\n";
This check is run in each ite
hokein updated this revision to Diff 79194.
hokein marked 2 inline comments as done.
hokein added a comment.
Add comments && Update test.
https://reviews.llvm.org/D27059
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/tool/ClangMoveMain.cpp
unittests/clang-move/ClangMo
ioeric added inline comments.
Comment at: clang-move/ClangMove.h:90
+
+// When moving all declarations in old header, all code in old.h/cc will be
+// moved.
Is this the right place for this comment? Seems a bit unexpected.
Comment at: unittest
hokein updated this revision to Diff 79120.
hokein added a comment.
Code style.
https://reviews.llvm.org/D27059
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
clang-move/tool/ClangMoveMain.cpp
unittests/clang-move/ClangMoveTests.cpp
Index: unittests/clang-move/ClangMoveTests.cp
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
- Add -dump_dels option to dump all declarations from old header. It will allow
clang-move used as a frontend to get declarations from header. Further more,
this will make debugging stuff easie
