[PATCH] D27033: [ASTImporter] Support importing UnresolvedLookupExpr nodes

2016-11-29 Thread Sean Callanan via Phabricator via cfe-commits
spyffe added a comment. Marked the place I was talking about in D27181 Comment at: lib/AST/ASTImporter.cpp:6489 + DeclarationNameInfo NameInfo(E->getName(), E->getNameLoc()); + ImportDeclarationNameLoc(E->getNameInfo(), NameInfo); + -

[PATCH] D27033: [ASTImporter] Support importing UnresolvedLookupExpr nodes

2016-11-28 Thread Sean Callanan via Phabricator via cfe-commits
spyffe added a comment. I only have a stylistic nit to add to Aleksei's comments. Comment at: lib/AST/ASTImporter.cpp:6492 + UnresolvedSet<8> ToDecls; + for (UnresolvedLookupExpr::decls_iterator S = E->decls_begin(), +F = E->decls_e

[PATCH] D27033: [ASTImporter] Support importing UnresolvedLookupExpr nodes

2016-11-23 Thread Aleksei Sidorin via cfe-commits
a.sidorin requested changes to this revision. a.sidorin added a reviewer: a.sidorin. a.sidorin added a comment. This revision now requires changes to proceed. Hi Kareem! I'll be happy to see this changes in upstream. Please see my comments inline. Comment at: lib/AST/ASTImport

[PATCH] D27033: [ASTImporter] Support importing UnresolvedLookupExpr nodes

2016-11-22 Thread Kareem Khazem via cfe-commits
khazem created this revision. khazem added reviewers: spyffe, dergachev.a. khazem added subscribers: cfe-commits, phosek, seanklein. This patch adds support for importing AST nodes of type UnresolvedLookupExpr, as well as a test for such an import. This resolves an issue where attempting to impo