rnk added inline comments.
Comment at: lib/Sema/SemaExprCXX.cpp:861
// friendship or any other means).
Context.addCopyConstructorForExceptionObject(Subobject, CD);
rsmith wrote:
> It would seem a lot more reasonable to actually form an expression
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287774: Remove C++ default arg side table for MS ABI ctor
closures (authored by rnk).
Changed prior to commit:
https://reviews.llvm.org/D27007?vs=78965&id=79105#toc
Repository:
rL LLVM
https://revie
rsmith accepted this revision.
rsmith added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Sema/SemaExprCXX.cpp:861
// friendship or any other means).
Context.addCopyConstructorForExceptionObject(Subobject, CD);
rnk added a comment.
It's worth pointing out that we have a few more side tables right next door in
ASTContext, addCopyConstructorForExceptionObject /
getCopyConstructorForExceptionObject. It looks like if those aren't populated,
they we might copy the bytes of an exception when catching someth
rnk created this revision.
rnk added reviewers: thakis, rsmith, majnemer.
rnk added a subscriber: cfe-commits.
We don't need a side table in ASTContext to hold CXXDefaultArgExprs. The
important part of building the CXXDefaultArgExprs was to ODR use the
default argument expressions, not to make AST
