mgorny added a comment.
As discussed on IRC, I will commit the unconditional versions for projects that
require the same version of LLVM (clang, lldb, lld) and the version with
fallback for others (runtimes).
https://reviews.llvm.org/D26900
___
cf
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291495: [cmake] Obtain LLVM_CMAKE_PATH from llvm-config
(authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D26900?vs=83527&id=83718#toc
Repository:
rL LLVM
https://reviews.llvm.
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm I figure we've waited a few days at this point.
https://reviews.llvm.org/D26900
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
mgorny retitled this revision from "[cmake] Obtain LLVM_CMAKE_PATH from
llvm-config" to "[cmake] Obtain LLVM_CMAKE_PATH from llvm-config if available".
mgorny updated the summary for this revision.
mgorny updated this revision to Diff 83527.
mgorny added a comment.
Updated to support fallback to
mgorny added a comment.
In https://reviews.llvm.org/D26900#638328, @EricWF wrote:
> Is there a way to write this patch so that old `llvm-config`'s continue to
> work, at least for a little while until everybody upgrades?
Technically it's possible but I think it would add a lot of complexity. S
EricWF added a comment.
Is there a way to write this patch so that old `llvm-config`'s continue to
work, at least for a little while until everybody upgrades?
https://reviews.llvm.org/D26900
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
mgorny added reviewers: EricWF, mclow.lists, phosek, compnerd, Hahnfeld.
mgorny added a comment.
Little ping here. This is quite trivial, and since
https://reviews.llvm.org/D26894 has been committed already I'd like to start
adding changes like this one to all LLVM projects using llvm-config in
mgorny created this revision.
mgorny added reviewers: beanz, rnk, chapuni, chandlerc.
mgorny added a subscriber: cfe-commits.
Use the new --cmakedir option to obtain LLVM_CMAKE_PATH straight from
llvm-config instead of reconstructing it locally.
https://reviews.llvm.org/D26900
Files:
CMakeLis
