nwilson added a comment.
Small Ping. @rsmith - did you have anymore thoughts about this patch?
https://reviews.llvm.org/D26882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nwilson updated this revision to Diff 82194.
nwilson added a comment.
- Remove the call to `setImplicitlyInline()` within `setImplicitlyConstexpr()`
and call `setImplicitlyInline()` directly for function concepts.
https://reviews.llvm.org/D26882
Files:
include/clang/AST/Decl.h
lib/Sema/Sem
rsmith added inline comments.
Comment at: include/clang/AST/Decl.h:1923
+IsConstexpr = IC;
+setImplicitlyInline();
+ }
nwilson wrote:
> hubert.reinterpretcast wrote:
> > I am quite sure this is not the right thing to do when `IC` is `false`.
> Good point
nwilson added a comment.
Ping
https://reviews.llvm.org/D26882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nwilson added a comment.
https://reviews.llvm.org/D26882
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nwilson updated this revision to Diff 80845.
nwilson added a comment.
- Initialize IsConstexprSpecified
- Remove unnecessary parenthetical in comment
- Fix non-portable test
https://reviews.llvm.org/D26882
Files:
include/clang/AST/Decl.h
lib/Sema/SemaDecl.cpp
lib/Sema/SemaDeclCXX.cpp
li
nwilson added inline comments.
Comment at: include/clang/AST/Decl.h:1915
+IsConstexprSpecified = IC;
+IsConstexpr = IC;
+ }
hubert.reinterpretcast wrote:
> How is the `inline` property transmitted here? Why does the
> `setImplicitlyConstexpr` function n
hubert.reinterpretcast added inline comments.
Comment at: include/clang/AST/Decl.h:1915
+IsConstexprSpecified = IC;
+IsConstexpr = IC;
+ }
How is the `inline` property transmitted here? Why does the
`setImplicitlyConstexpr` function need to call `setImp
