EricWF closed this revision.
EricWF added a comment.
Committed on behalf of @AntonBikineev in r290744.
https://reviews.llvm.org/D26829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AntonBikineev added a comment.
@rsmith Richard, any plans to merge this or is there anything left?
https://reviews.llvm.org/D26829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AntonBikineev updated this revision to Diff 78739.
https://reviews.llvm.org/D26829
Files:
include/clang/Lex/LiteralSupport.h
lib/Lex/Lexer.cpp
lib/Lex/LiteralSupport.cpp
lib/Sema/SemaDeclCXX.cpp
test/SemaCXX/cxx1z-user-defined-literals.cpp
Index: test/SemaCXX/cxx1z-user-defined-litera
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
Comment at: lib/Lex/Lexer.cpp:1717
+ const StringRef CompleteSuffix(Buffer, Chars);
+ const LangOptions &LangOpts = getLangOpts();
+
AntonBikineev updated this revision to Diff 78654.
AntonBikineev added a comment.
Richard, thanks, I addressed your comments.
https://reviews.llvm.org/D26829
Files:
include/clang/Lex/LiteralSupport.h
lib/Lex/Lexer.cpp
lib/Lex/LiteralSupport.cpp
lib/Sema/SemaDeclCXX.cpp
test/SemaCXX/cx
On 19 Nov 2016 2:36 am, "Anton Bikineev" wrote:
AntonBikineev added inline comments.
Comment at: lib/Lex/LiteralSupport.cpp:1716-1717
+StringLiteralParser::UDSuffixResult
+StringLiteralParser::isValidUDSuffix(const LangOptions &LangOpts,
+ St
AntonBikineev added inline comments.
Comment at: lib/Lex/LiteralSupport.cpp:1716-1717
+StringLiteralParser::UDSuffixResult
+StringLiteralParser::isValidUDSuffix(const LangOptions &LangOpts,
+ StringRef Suffix) {
+ if (!LangOpts.CPlusPlus11 ||
rsmith added inline comments.
Comment at: include/clang/Basic/DiagnosticLexKinds.td:189-190
InGroup, DefaultIgnore;
+def err_cxx1z_string_view_literal : Error<
+ "string_view literals are a C++1z feature">;
def ext_binary_literal : Extension<
I don't see a n
AntonBikineev added a comment.
In https://reviews.llvm.org/D26829#599906, @malcolm.parsons wrote:
> Does `Sema::CheckLiteralOperatorDeclaration` need to check
> `StringLiteralParser::isValidUDSuffix`?
Thanks, nice point! Just addressed it.
https://reviews.llvm.org/D26829
_
AntonBikineev updated this revision to Diff 78602.
https://reviews.llvm.org/D26829
Files:
include/clang/Basic/DiagnosticLexKinds.td
include/clang/Lex/LiteralSupport.h
lib/Lex/Lexer.cpp
lib/Lex/LiteralSupport.cpp
lib/Sema/SemaDeclCXX.cpp
test/SemaCXX/cxx1z-user-defined-literals.cpp
In
malcolm.parsons added a comment.
Does `Sema::CheckLiteralOperatorDeclaration` need to check
`StringLiteralParser::isValidUDSuffix`?
https://reviews.llvm.org/D26829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
AntonBikineev updated this revision to Diff 78523.
AntonBikineev added a comment.
Just added a small test case
https://reviews.llvm.org/D26829
Files:
include/clang/Basic/DiagnosticLexKinds.td
include/clang/Lex/LiteralSupport.h
lib/Lex/Lexer.cpp
lib/Lex/LiteralSupport.cpp
test/SemaCXX/
AntonBikineev updated this revision to Diff 78511.
https://reviews.llvm.org/D26829
Files:
include/clang/Basic/DiagnosticLexKinds.td
include/clang/Lex/LiteralSupport.h
lib/Lex/Lexer.cpp
lib/Lex/LiteralSupport.cpp
Index: lib/Lex/LiteralSupport.cpp
==
AntonBikineev updated this revision to Diff 78510.
https://reviews.llvm.org/D26829
Files:
include/clang/Basic/DiagnosticLexKinds.td
include/clang/Lex/LiteralSupport.h
lib/Lex/Lexer.cpp
lib/Lex/LiteralSupport.cpp
Index: lib/Lex/LiteralSupport.cpp
==
AntonBikineev updated the summary for this revision.
AntonBikineev updated this revision to Diff 78507.
https://reviews.llvm.org/D26829
Files:
include/clang/Basic/DiagnosticLexKinds.td
include/clang/Lex/LiteralSupport.h
lib/Lex/Lexer.cpp
lib/Lex/LiteralSupport.cpp
Index: lib/Lex/LiteralS
AntonBikineev updated this revision to Diff 78490.
https://reviews.llvm.org/D26829
Files:
include/clang/Basic/DiagnosticLexKinds.td
lib/Lex/Lexer.cpp
Index: lib/Lex/Lexer.cpp
===
--- lib/Lex/Lexer.cpp
+++ lib/Lex/Lexer.cpp
@@ -
EricWF added a comment.
Should this review be closed then?
https://reviews.llvm.org/D26829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
malcolm.parsons added a comment.
@mclow.lists is working on this in https://reviews.llvm.org/D26667.
The review comments from that apply here too.
https://reviews.llvm.org/D26829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
EricWF added a comment.
Please add tests to `cxx1y-user-defined-literals.cpp` (and probably rename it).
Other than that this LGTM, but I don't feel comfortable approving clang patches.
https://reviews.llvm.org/D26829
___
cfe-commits mailing list
cf
AntonBikineev created this revision.
AntonBikineev added reviewers: mclow.lists, rsmith, cfe-commits.
https://reviews.llvm.org/D26829
Files:
lib/Lex/Lexer.cpp
Index: lib/Lex/Lexer.cpp
===
--- lib/Lex/Lexer.cpp
+++ lib/Lex/Lexer.c
20 matches
Mail list logo
