[PATCH] D26826: [libcxx] Implement locale.h to fix modules build

2016-11-18 Thread Eric Fiselier via cfe-commits
EricWF added inline comments. Comment at: include/locale.h:2 +// -*- C++ -*- +//=== math.h --===// +// rsmith wrote: > This is not math.h. It was fixed before committing but I didn't update phab. http

[PATCH] D26826: [libcxx] Implement locale.h to fix modules build

2016-11-18 Thread Richard Smith via cfe-commits
rsmith added a comment. This should only be needed if you are not using `-fmodules-local-submodule-visibility` and do not have a module map for your C standard library. Is that really a configuration we want to support? Building without `-fmodules-local-submodule-visibility` typically only work

[PATCH] D26826: [libcxx] Implement locale.h to fix modules build

2016-11-17 Thread Eric Fiselier via cfe-commits
EricWF created this revision. EricWF added reviewers: mclow.lists, rsmith. EricWF added a subscriber: cfe-commits. Because `locale.h` isn't part of the libc++ modules the class definitions it provides are exported as part of `__locale` (since it happens to be build first). This breaks `` which e