STL_MSFT abandoned this revision.
STL_MSFT added a comment.
r289358 fixes everything for me, thanks! Abandoning this revision.
https://reviews.llvm.org/D26623
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
EricWF added a comment.
I hope you don't mind but I committed by own version of this change as r289358.
I was concerned about testing that the container didn't actually perform a
swap, so I modified test_allocator to take an "id" parameter that does not
participate in equality. I then changed t
STL_MSFT updated this revision to Diff 80352.
STL_MSFT added a comment.
Merged with the recent addition of static_cast to various lines in
the unordered container tests. No actual changes to the diff, only to the
context.
https://reviews.llvm.org/D26623
Files:
test/std/containers/associativ
mclow.lists added a comment.
I'm working on this, too.
Trying to decide what the right choice is here.
https://reviews.llvm.org/D26623
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Swapping non-equal non-POCS allocators is UB.
test_allocator is a non-POCS allocator. Instead of swapping containers
with A(1) and A(2), which triggers undefine
