This revision was automatically updated to reflect the committed changes.
Closed by commit rL289744: Use PIC relocation mode by default for PowerPC64 ELF
(authored by joerg).
Changed prior to commit:
https://reviews.llvm.org/D26564?vs=77670&id=81495#toc
Repository:
rL LLVM
https://reviews.l
hfinkel accepted this revision.
hfinkel added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D26564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
joerg added a comment.
Ping
https://reviews.llvm.org/D26564
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
amehsan added inline comments.
Comment at: lib/Driver/ToolChains.cpp:2799-2807
+ switch (getArch()) {
+ case llvm::Triple::x86_64:
+return getTriple().isOSWindows();
+ case llvm::Triple::ppc64:
+ case llvm::Triple::ppc64le:
+return !getTriple().isOSBinFormatMachO() &&
wschmidt added a comment.
In https://reviews.llvm.org/D26564#593352, @hfinkel wrote:
> @wschmidt and other IBM folks, w.r.t. this and
> https://reviews.llvm.org/D26566, can you please comment on what GCC does
> here? Does GCC use -fPIC by default for PPC64 (literally or in effect)?
This is an
hfinkel added a comment.
@wschmidt and other IBM folks, w.r.t. this and https://reviews.llvm.org/D26566,
can you please comment on what GCC does here? Does GCC use -fPIC by default for
PPC64 (literally or in effect)?
https://reviews.llvm.org/D26564
__
joerg created this revision.
joerg added a reviewer: hfinkel.
joerg added a subscriber: cfe-commits.
Herald added a subscriber: nemanjai.
Most of the PowerPC64 code generation already creates PIC access. This changes
to a full PIC default, similar to what GCC is doing.
Overall, a monolithic clan
