This revision was automatically updated to reflect the committed changes.
Closed by commit rL286943: [clang-move] Make the output code look more pretty.
(authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D26493?vs=77821&id=77958#toc
Repository:
rL LLVM
https://reviews.l
hokein updated this revision to Diff 77821.
hokein added a comment.
Remove a trailing blank line.
https://reviews.llvm.org/D26493
Files:
clang-move/ClangMove.cpp
unittests/clang-move/ClangMoveTests.cpp
Index: unittests/clang-move/ClangMoveTests.cpp
=
hokein updated this revision to Diff 77820.
hokein marked an inline comment as done.
hokein added a comment.
Fix a corner case, and add a test.
https://reviews.llvm.org/D26493
Files:
clang-move/ClangMove.cpp
unittests/clang-move/ClangMoveTests.cpp
Index: unittests/clang-move/ClangMoveTests
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:280
assert(It < CurrentNamespaces.rend());
- NewCode += "} // namespace " + *It + "\n";
+ NewCode += "} // namespace " + *It + "\n\n";
}
hokein wrote:
> ioeric wrote:
> > Wou
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:280
assert(It < CurrentNamespaces.rend());
- NewCode += "} // namespace " + *It + "\n";
+ NewCode += "} // namespace " + *It + "\n\n";
}
ioeric wrote:
> Wouldn't this create
ioeric added a comment.
Lg with one nit.
Comment at: clang-move/ClangMove.cpp:280
assert(It < CurrentNamespaces.rend());
- NewCode += "} // namespace " + *It + "\n";
+ NewCode += "} // namespace " + *It + "\n\n";
}
Wouldn't this create som
hokein updated this revision to Diff 77794.
hokein added a comment.
Add comments and update patch descriptions.
https://reviews.llvm.org/D26493
Files:
clang-move/ClangMove.cpp
unittests/clang-move/ClangMoveTests.cpp
Index: unittests/clang-move/ClangMoveTests.cpp
===
ioeric added inline comments.
Comment at: clang-move/ClangMove.cpp:273
}
+bool IsNamespaceStart = false;
while (DeclIt != DeclNamespaces.end()) {
It's been a while since the last time I reviewed this, and I need to struggle
to understand what Curre
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
Add decent blank line between declarations.
https://reviews.llvm.org/D26493
Files:
clang-move/ClangMove.cpp
unittests/clang-move/ClangMoveTests.cpp
Index: unittests/clang-move/ClangMoveTe
