george.burgess.iv abandoned this revision.
george.burgess.iv added a comment.
Committed in https://reviews.llvm.org/rL290149. Thanks again!
https://reviews.llvm.org/D26410
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
george.burgess.iv updated this revision to Diff 77669.
george.burgess.iv marked an inline comment as done.
george.burgess.iv added a comment.
Thanks for the review!
I'll submit this with https://reviews.llvm.org/D14274. :)
https://reviews.llvm.org/D26410
Files:
lib/CodeGen/CGBlocks.cpp
lib
rjmccall added a comment.
This looks great. One minor tweak and then it's ready.
Comment at: lib/CodeGen/CGBlocks.cpp:1057
+void CodeGenModule::putAddrOfGlobalBlock(const BlockExpr *BE,
+ llvm::Constant *Addr) {
+ bool Ok = EmittedGloba
george.burgess.iv created this revision.
george.burgess.iv added a reviewer: rjmccall.
george.burgess.iv added a subscriber: cfe-commits.
https://reviews.llvm.org/D14274 makes our constexpr evaluator more aggressive
with some variables marked `const`. This changes how we behave on code like the
