[PATCH] D26406: Add -Wduplicate-protocol for existing diagnostic

This revision was automatically updated to reflect the committed changes. Closed by commit rL286487: Add -Wduplicate-protocol for existing diagnostic (authored by arphaman). Changed prior to commit: https://reviews.llvm.org/D26406?vs=77232&id=77514#toc Repository: rL LLVM https://reviews.ll

[PATCH] D26406: Add -Wduplicate-protocol for existing diagnostic

arphaman added a comment. It seems sufficient enough, I will commit it with the summary. Thanks! https://reviews.llvm.org/D26406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26406: Add -Wduplicate-protocol for existing diagnostic

kastiglione added a comment. @arphaman Is the summary here sufficient, or should I elaborate in some way? I'm fine with this summary if you are. https://reviews.llvm.org/D26406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.ll

[PATCH] D26406: Add -Wduplicate-protocol for existing diagnostic

arphaman added a comment. In https://reviews.llvm.org/D26406#590741, @kastiglione wrote: > Thanks @arphaman, are you able to commit this? Yes, I can commit this for you. Let me know what commit message I should use. https://reviews.llvm.org/D26406 __

[PATCH] D26406: Add -Wduplicate-protocol for existing diagnostic

kastiglione added a comment. Thanks @arphaman, are you able to commit this? https://reviews.llvm.org/D26406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26406: Add -Wduplicate-protocol for existing diagnostic

arphaman accepted this revision. arphaman added a reviewer: arphaman. arphaman added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D26406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

[PATCH] D26406: Add -Wduplicate-protocol for existing diagnostic

kastiglione updated this revision to Diff 77232. kastiglione added a comment. Added test https://reviews.llvm.org/D26406 Files: include/clang/Basic/DiagnosticSemaKinds.td test/Misc/warning-flags.c test/SemaObjC/check-dup-objc-decls-1.m Index: test/SemaObjC/check-dup-objc-decls-1.m =

[PATCH] D26406: Add -Wduplicate-protocol for existing diagnostic

kastiglione added a comment. @arphaman I wondered whether this called for a test. I'm happy to add one just like that. https://reviews.llvm.org/D26406 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D26406: Add -Wduplicate-protocol for existing diagnostic

arphaman added a comment. I'm not sure that it's required, but shouldn't we have also have a test that checks for the usage of this flag as well? Adding a test case with `#pragma clang diagnostic ignored "-Wduplicate-protocol"` and some code to a file like "test/SemaObjC/check-dup-objc-decls-1.

[PATCH] D26406: Add -Wduplicate-protocol for existing diagnostic

kastiglione created this revision. kastiglione added a reviewer: cfe-commits. Expose a warning flag for `warn_duplicate_protocol_def`. This allows control over the severity of duplicate protocol definitions. For example `-Werror=duplicate-protocol` or `#pragma clang diagnostic ignored "-Wduplicat