rsmith added a comment.
LGTM
https://reviews.llvm.org/D26345
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jackoalan updated this revision to Diff 86088.
jackoalan added a comment.
Herald added a subscriber: nemanjai.
Remove already-aliased option matchings; add test case for patch.
https://reviews.llvm.org/D26345
Files:
lib/Driver/Tools.cpp
test/Driver/ppc-eabi-small-data.c
Index: test/Driver
rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.
As of r293254, the `-G=` and `-msmall-data-threshold=` flags are just aliases
of `-G`, so you don't need those parts of this patch any more. The PPC part
looks fine, but please add a testcase.
