[PATCH] D26316: [coroutines] Build and pass coroutine_handle to await_suspend.

GorNishanov closed this revision. GorNishanov added a comment. Commited as: https://reviews.llvm.org/rL297356 https://reviews.llvm.org/D26316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D26316: [coroutines] Build and pass coroutine_handle to await_suspend.

GorNishanov updated this revision to Diff 91119. GorNishanov added a comment. preparing to land https://reviews.llvm.org/D26316 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCoroutine.cpp lib/Sema/SemaExprMember.cpp test/CodeGenCoroutines/coro-alloc.cpp test/CodeGenCo

[PATCH] D26316: [coroutines] Build and pass coroutine_handle to await_suspend.

GorNishanov updated this revision to Diff 91117. GorNishanov added a comment. - Addressed nits - Improved error messages even further - Merge on top of the trunk Preparing to land https://reviews.llvm.org/D26316 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCoroutine.cpp

[PATCH] D26316: [coroutines] Build and pass coroutine_handle to await_suspend.

EricWF added a comment. @GorNishanov You forgot to update `test/SemaCXX/coreturn.cpp`. https://reviews.llvm.org/D26316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26316: [coroutines] Build and pass coroutine_handle to await_suspend.

EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. On second thought if @rsmith already reviewed most of this offline then I feel comfortable giving it the thumbs up. https://reviews.llvm.org/D26316

[PATCH] D26316: [coroutines] Build and pass coroutine_handle to await_suspend.

EricWF added a comment. This LGTM, but I don't know enough Clang to be 100% on it. Perhaps somebody else could give it a quick second look? Comment at: lib/Sema/SemaCoroutine.cpp:157 + if (S.RequireCompleteType(Loc, CoroHandleType, +diag::err_corou

[PATCH] D26316: [coroutines] Build and pass coroutine_handle to await_suspend.

GorNishanov added a comment. @EricWF, LGTM? https://reviews.llvm.org/D26316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26316: [coroutines] Build and pass coroutine_handle to await_suspend.

GorNishanov updated this revision to Diff 90862. GorNishanov added a comment. - removed '&' that snicked near Location parameter - reordered a few lines to minimize the diff from Eric's version https://reviews.llvm.org/D26316 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCo

[PATCH] D26316: [coroutines] Build and pass coroutine_handle to await_suspend.

GorNishanov updated this revision to Diff 90861. GorNishanov added a comment. Per's @rsmith feedback in Kona - Added diagnostic if from_address is missing from coroutine_handle - Switch to using BuildDeclarationNameExpr in buildCoroutineHandle https://reviews.llvm.org/D26316 Files: include/c

[PATCH] D26316: [coroutines] Build and pass coroutine_handle to await_suspend.

GorNishanov commandeered this revision. GorNishanov edited reviewers, added: EricWF; removed: GorNishanov. GorNishanov added a comment. Comandeering this patch. Last week Richard gave me some feedback in person on this code (in the full coroutine implementation not this patch in particular). I am

[PATCH] D26316: [coroutines] Build and pass coroutine_handle to await_suspend.

EricWF updated this revision to Diff 88852. EricWF added a comment. - Update so that it merges with https://reviews.llvm.org/D26057 https://reviews.llvm.org/D26316 Files: include/clang/Basic/DiagnosticSemaKinds.td lib/Sema/SemaCoroutine.cpp lib/Sema/SemaExprMember.cpp test/CodeGenCorout

[PATCH] D26316: [coroutines] Build and pass coroutine_handle to await_suspend.

EricWF created this revision. EricWF added reviewers: rsmith, GorNishanov. EricWF added a subscriber: cfe-commits. Herald added a subscriber: mehdi_amini. This patch adds passing a `coroutine_handle` object to `await_suspend` calls. It builds the `coroutine_handle` using `coroutine_handle::from