This revision was automatically updated to reflect the committed changes.
jlebar marked 2 inline comments as done.
Closed by commit rL286313: [CUDA] Use only the GVALinkage on function
definitions. (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D26268?vs=76808&id=77280#
jlebar marked 2 inline comments as done.
jlebar added a comment.
Thank you for the review! Submitting...
Comment at: clang/test/SemaCUDA/add-inline-in-definition.cu:13-14
+//
+// The trickiness here comes from the fact that the FunctionDecl bar() sees for
+// foo() does not ha
tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: clang/test/SemaCUDA/add-inline-in-definition.cu:13-14
+//
+// The trickiness here comes from the fact that the FunctionDecl bar() sees for
+// foo() does not have
jlebar added a comment.
Friendly ping
https://reviews.llvm.org/D26268
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: rsmith, cfe-commits.
Previously we'd look at the GVALinkage of whatever FunctionDecl you
happened to be calling.
This is not right. In the absence of the gnu_inline attribute, to be
handled separately, the func
