This revision was automatically updated to reflect the committed changes.
Closed by commit rL296242: [analyzer] Refactor and simplify
SimpleConstraintManager (authored by ddcc).
Changed prior to commit:
https://reviews.llvm.org/D26061?vs=89054&id=89773#toc
Repository:
rL LLVM
https://review
ddcc updated this revision to Diff 89054.
ddcc added a comment.
Rebase, incorporate https://reviews.llvm.org/D22862
https://reviews.llvm.org/D26061
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h
include/clang/StaticAnalyzer/Core/PathSensitive/SimpleConstraintMana
ddcc updated this revision to Diff 85136.
ddcc added a comment.
Rebase
https://reviews.llvm.org/D26061
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h
include/clang/StaticAnalyzer/Core/PathSensitive/SimpleConstraintManager.h
lib/StaticAnalyzer/Core/CMakeLists.tx
ddcc added a comment.
How does this look now?
https://reviews.llvm.org/D26061
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ddcc updated this revision to Diff 80129.
ddcc added a comment.
Rebase, move `assumeSymRel()` to RangedConstraintManager, make
`assumeSymUnsupported` pure virtual in SimpleConstraintManager.
https://reviews.llvm.org/D26061
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintMana
ddcc updated this revision to Diff 78049.
ddcc added a comment.
Rebase on recent changes
https://reviews.llvm.org/D26061
Files:
include/clang/StaticAnalyzer/Core/PathSensitive/ConstraintManager.h
include/clang/StaticAnalyzer/Core/PathSensitive/SimpleConstraintManager.h
lib/StaticAnalyzer/
ddcc added a comment.
Yes, I've been writing a Z3 solver interface, which motivated this patch.
However, this patch has snowballed into something that it's a little too
convoluted, so I'll split it up.
I'm not sure whether the RangedConstraintManager interface is useful or not; I
preserved it
dcoughlin added a comment.
Thanks for the patch!
Would it be possible to split this up into several patches? I think it is
important to separate the interface layering changes from the formatting
changes, renaming changes, and minor optimization changes. This will make the
patches easier to re
ddcc added a comment.
To summarize, here is a list of changes:
- General
- Fixed some issues with formatting (`clang-format`)
- Fixed inconsistent capitalization following camel case style guidelines
- `ConstraintManager.h`
- Renamed `assumeWithinInclusiveRange*()` to `assumeInclusiveRange
ddcc created this revision.
ddcc added reviewers: zaks.anna, dcoughlin.
ddcc added subscribers: cfe-commits, rgov, NoQ, xazax.hun.
Herald added a subscriber: mgorny.
SimpleConstraintManager is difficult to use, and makes assumptions about
capabilities of the constraint manager. This patch refacto
10 matches
Mail list logo
