This revision was automatically updated to reflect the committed changes.
Closed by commit rL285391: [Objective-C] Add objc_subclassing_restricted
attribute (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D25993?vs=76019&id=76175#toc
Repository:
rL LLVM
https://rev
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Sema/SemaDeclObjC.cpp:3859
+// objc_subclassing_restricted attribute when it has that attribute as
+// well (because of int
arphaman added inline comments.
Comment at: lib/Sema/SemaDeclObjC.cpp:3859
+// objc_subclassing_restricted attribute when it has that attribute as
+// well (because of interfaces imported from Swift). Therefore we have
+// to check if we can subclass in th
aaron.ballman added inline comments.
Comment at: lib/Sema/SemaDeclObjC.cpp:3859
+// objc_subclassing_restricted attribute when it has that attribute as
+// well (because of interfaces imported from Swift). Therefore we have
+// to check if we can subclass
arphaman updated this revision to Diff 76019.
arphaman marked 3 inline comments as done.
arphaman added a comment.
The updated patch adds documentation and modifies the diagnostic message.
Repository:
rL LLVM
https://reviews.llvm.org/D25993
Files:
include/clang/Basic/Attr.td
include/clan
aaron.ballman requested changes to this revision.
aaron.ballman added inline comments.
This revision now requires changes to proceed.
Comment at: include/clang/Basic/Attr.td:1291
+ let Subjects = SubjectList<[ObjCInterface], ErrorDiag>;
+ let Documentation = [Undocumented];
+}
manmanren accepted this revision.
manmanren added a reviewer: manmanren.
manmanren added a comment.
This revision is now accepted and ready to land.
LGTM.
Manman
Repository:
rL LLVM
https://reviews.llvm.org/D25993
___
cfe-commits mailing list
cf
jordan_rose added a comment.
Looks good from my end.
Repository:
rL LLVM
https://reviews.llvm.org/D25993
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman created this revision.
arphaman added reviewers: aaron.ballman, jordan_rose.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch adds an `objc_subclassing_restricted` attribute into clang. This
attribute acts similarly to 'final'
