This revision was automatically updated to reflect the committed changes.
Closed by commit rL285193: [PP] Replace some index based for loops with range
based ones (authored by erikjv).
Changed prior to commit:
https://reviews.llvm.org/D25982?vs=75854&id=75867#toc
Repository:
rL LLVM
https:/
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D25982
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
erikjv updated this revision to Diff 75854.
erikjv marked an inline comment as done.
https://reviews.llvm.org/D25982
Files:
lib/Lex/PPCaching.cpp
lib/Lex/PPLexerChange.cpp
lib/Lex/PPMacroExpansion.cpp
lib/Lex/Pragma.cpp
lib/Lex/TokenConcatenation.cpp
lib/Lex/TokenLexer.cpp
Index: lib
bkramer added inline comments.
Comment at: lib/Lex/PPLexerChange.cpp:43
"Top level include stack isn't our primary lexer?");
- for (unsigned i = 1, e = IncludeMacroStack.size(); i != e; ++i)
-if (IsFileLexer(IncludeMacroStack[i]))
+ for (const IncludeStackInfo &IS
erikjv created this revision.
erikjv added a reviewer: bkramer.
erikjv added a subscriber: cfe-commits.
Herald added subscribers: anna, nemanjai.
While in the area, also change some unsigned variables to size_t, and
introduce an LLVM_FALLTHROUGH instead of a comment stating that.
https://reviews
