[PATCH] D25811: [libcxx] Fix toupper/tolower tests for UTF-8 locale

2017-01-03 Thread Krzysztof Parzyszek via Phabricator via cfe-commits
kparzysz abandoned this revision. kparzysz added a comment. In https://reviews.llvm.org/D25811#632670, @EricWF wrote: > While I was attempting to review this patch I ended up coming up with fixed > tests myself. I committed them in r290746. I'm very sorry to step on your > toes. No problem at

[PATCH] D25811: [libcxx] Fix toupper/tolower tests for UTF-8 locale

2016-12-30 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF added a comment. In https://reviews.llvm.org/D25811#586053, @kparzysz wrote: > In https://reviews.llvm.org/D25811#586000, @arphaman wrote: > > > I've tested this patch on OS X and these 4 tests that you've changed now > > fail. > > > > The `XFAIL: with_system_cxx_lib` lines don't have any

[PATCH] D25811: [libcxx] Fix toupper/tolower tests for UTF-8 locale

2016-11-02 Thread Alex Lorenz via cfe-commits
arphaman added a comment. In https://reviews.llvm.org/D25811#586053, @kparzysz wrote: > In https://reviews.llvm.org/D25811#586000, @arphaman wrote: > > > I've tested this patch on OS X and these 4 tests that you've changed now > > fail. > > > > The `XFAIL: with_system_cxx_lib` lines don't have a

[PATCH] D25811: [libcxx] Fix toupper/tolower tests for UTF-8 locale

2016-11-02 Thread Krzysztof Parzyszek via cfe-commits
kparzysz added a comment. And thanks for help. :) Repository: rL LLVM https://reviews.llvm.org/D25811 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25811: [libcxx] Fix toupper/tolower tests for UTF-8 locale

2016-11-02 Thread Krzysztof Parzyszek via cfe-commits
kparzysz added a comment. In https://reviews.llvm.org/D25811#586000, @arphaman wrote: > I've tested this patch on OS X and these 4 tests that you've changed now fail. > > The `XFAIL: with_system_cxx_lib` lines don't have any effect on my system - > these tests get invoked as expected by lit. Let

[PATCH] D25811: [libcxx] Fix toupper/tolower tests for UTF-8 locale

2016-11-02 Thread Alex Lorenz via cfe-commits
arphaman added a comment. I've tested this patch on OS X and these 4 tests that you've changed now fail. The `XFAIL: with_system_cxx_lib` lines don't have any effect on my system - these tests get invoked as expected by lit. Let me know if there's anything else I can do to help you. Repositor

[PATCH] D25811: [libcxx] Fix toupper/tolower tests for UTF-8 locale

2016-10-20 Thread Krzysztof Parzyszek via cfe-commits
kparzysz updated this revision to Diff 75292. kparzysz added a comment. Unxfail these tests on Linux. Repository: rL LLVM https://reviews.llvm.org/D25811 Files: test/std/localization/locale.categories/category.ctype/locale.ctype.byname/tolower_1.pass.cpp test/std/localization/locale.ca

[PATCH] D25811: [libcxx] Fix toupper/tolower tests for UTF-8 locale

2016-10-20 Thread Krzysztof Parzyszek via cfe-commits
kparzysz added a comment. In https://reviews.llvm.org/D25811#575105, @EricWF wrote: > Seems like we should figure out why these pass on ToT OS X. All of them have // XFAIL: with_system_cxx_lib=x86_64-apple-darwin11 // XFAIL: with_system_cxx_lib=x86_64-apple-darwin12 Maybe that's it. I don't

[PATCH] D25811: [libcxx] Fix toupper/tolower tests for UTF-8 locale

2016-10-19 Thread Eric Fiselier via cfe-commits
EricWF added a comment. Seems like we should figure out why these pass on ToT OS X. Repository: rL LLVM https://reviews.llvm.org/D25811 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D25811: [libcxx] Fix toupper/tolower tests for UTF-8 locale

2016-10-19 Thread Krzysztof Parzyszek via cfe-commits
kparzysz created this revision. kparzysz added a reviewer: EricWF. kparzysz added a subscriber: cfe-commits. kparzysz set the repository for this revision to rL LLVM. The characters like '\xDA' or '\xFA' are not valid representations of anything in UTF-8, so toupper and tolower return the charact