This revision was automatically updated to reflect the committed changes.
hokein marked 2 inline comments as done.
Closed by commit rL284592: [clang-move] Move using-decl in old cc. (authored by
hokein).
Changed prior to commit:
https://reviews.llvm.org/D25762?vs=75139&id=75146#toc
Repository:
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Lg
Comment at: clang-move/ClangMove.cpp:372
+ // Match static functions/variabale definitions which are defined in named
+ // spaces.
+ auto IsOldCCStaticDefinition =
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:356
Finder->addMatcher(
- namedDecl(anyOf(functionDecl(isDefinition()), varDecl(isDefinition())),
-inAnonymousNamespace)
- .bind("decls_in_
hokein updated this revision to Diff 75139.
hokein marked 2 inline comments as done.
hokein added a comment.
Address comments.
- Cover type alias declarations.
- Fix an issue of moving function-scope static definitions in non-moved classes.
https://reviews.llvm.org/D25762
Files:
clang-move/C
ioeric added inline comments.
Comment at: clang-move/ClangMove.cpp:356
Finder->addMatcher(
- namedDecl(anyOf(functionDecl(isDefinition()), varDecl(isDefinition())),
-inAnonymousNamespace)
- .bind("decls_in_anonymous_ns"),
+ usingDecl(InOldCC,
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
Another fix is to move the whole anonymous namespace declaration
completely instead of moving fun/var declarations only.
https://reviews.llvm.org/D25762
Files:
clang-move/ClangMove.cpp
tes
