This revision was automatically updated to reflect the committed changes.
Closed by commit rL285582: [libc++] Add configuration define for off_t
functions (authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D25741?vs=75142&id=76411#toc
Repository:
rL LLVM
https://review
smeenai updated this revision to Diff 75142.
smeenai added a comment.
Addressing @mclow.lists's comment
https://reviews.llvm.org/D25741
Files:
include/__config
include/fstream
Index: include/fstream
===
--- include/fstream
++
mclow.lists added a comment.
I like this; I would like to see no mentions of `_WIN32` outside of
`<__config>`.
That being said, we usually write things in the negative in libc++.
So the flag would be `_LIBCPP_HAS_NO_OFF_T_FUNCTIONS`, and the tests would be
`#ifdef _LIBCPP_HAS_NO_OFF_T_FUNCTIONS
smeenai created this revision.
smeenai added reviewers: EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
Create this define in __config and use it elsewhere, instead of checking
the operating system/library defines in other files. The aim is to
reduce the usage of _WIN32 outside __con
