malcolm.parsons added inline comments.
Comment at: cfe/trunk/lib/Basic/SourceManager.cpp:1941
+MacroArgsCache = llvm::make_unique();
+computeMacroArgsCache(*MacroArgsCache.get(), FID);
+ }
Redundant .get()
Repository:
rL LLVM
https://reviews.llvm.or
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284442: [Basic] unique_ptr-ify
SourceManager::MacroArgsCacheMap (NFC) (authored by vedantk).
Changed prior to commit:
https://reviews.llvm.org/D25711?vs=74935&id=74937#toc
Repository:
rL LLVM
https:
jlebar accepted this revision.
jlebar added a comment.
This revision is now accepted and ready to land.
The great thing about unique_ptr is, if it compiles, we're probably good. :)
https://reviews.llvm.org/D25711
___
cfe-commits mailing list
cfe-co
vsk created this revision.
vsk added a reviewer: jlebar.
vsk added a subscriber: cfe-commits.
https://reviews.llvm.org/D25711
Files:
include/clang/Basic/SourceManager.h
lib/Basic/SourceManager.cpp
Index: lib/Basic/SourceManager.cpp
===
