[PATCH] D25674: [Concepts] Class template associated constraints

2017-02-09 Thread Richard Smith via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added inline comments. This revision is now accepted and ready to land. Comment at: lib/Sema/SemaTemplate.cpp:1300 + // Attach the associated constraints when the declaration will not be part of + // a decl chain + Expr *const ACtoAttach =

[PATCH] D25674: [Concepts] Class template associated constraints

2017-02-09 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast updated this revision to Diff 87855. hubert.reinterpretcast added a comment. Address review comments; update to revision 294580 Allocate ConstrainedTemplateDeclInfo separately Update comments to be sentences; NFC https://reviews.llvm.org/D25674 Files: include/clang/AS

[PATCH] D25674: [Concepts] Class template associated constraints

2017-02-08 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: include/clang/AST/DeclTemplate.h:373-391 +class TemplateDeclWithACBase { +protected: + TemplateDeclWithACBase() = default; + + ConstrainedTemplateDeclInfo CTDInfo; +}; + rsmith wrote: > This mechanism se

[PATCH] D25674: [Concepts] Class template associated constraints

2017-02-08 Thread Richard Smith via Phabricator via cfe-commits
rsmith added inline comments. Comment at: include/clang/AST/DeclTemplate.h:373-391 +class TemplateDeclWithACBase { +protected: + TemplateDeclWithACBase() = default; + + ConstrainedTemplateDeclInfo CTDInfo; +}; + This mechanism seems unnecessary to me; allocatin

[PATCH] D25674: [Concepts] Class template associated constraints

2017-02-08 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added a comment. Ping 2? https://reviews.llvm.org/D25674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25674: [Concepts] Class template associated constraints

2017-02-01 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast added a comment. Ping! https://reviews.llvm.org/D25674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25674: [Concepts] Class template associated constraints

2017-01-25 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast marked 3 inline comments as done. hubert.reinterpretcast added inline comments. Comment at: include/clang/AST/DeclTemplate.h:355 protected: - // This is probably never used. - TemplateDecl(Kind DK, DeclContext *DC, SourceLocation L, DeclarationName Name

[PATCH] D25674: [Concepts] Class template associated constraints

2017-01-25 Thread Hubert Tong via Phabricator via cfe-commits
hubert.reinterpretcast updated this revision to Diff 85752. hubert.reinterpretcast added a comment. Address review comments; update to revision 292996 Fix possibly ill-formed NDR case Test template-dependent cases for class redeclaration Address review comment: use lambda instead of do while(0)

[PATCH] D25674: [Concepts] Class template associated constraints

2016-10-27 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: include/clang/AST/DeclTemplate.h:412-417 + /// \brief The template parameter list and optional requires-clause + /// associated with this declaration. + /// + /// The boolean value indicates whether this particular declaration has an

[PATCH] D25674: [Concepts] Class template associated constraints

2016-10-24 Thread Hubert Tong via cfe-commits
hubert.reinterpretcast added a comment. Friendly ping... https://reviews.llvm.org/D25674 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25674: [Concepts] Class template associated constraints

2016-10-22 Thread Hubert Tong via cfe-commits
hubert.reinterpretcast added inline comments. Comment at: test/CXX/concepts-ts/temp/temp.constr/temp.constr.decl/class-template-decl.cpp:12 + +} // end namespace nodiag + I should probably add some template-dependent cases. https://reviews.llvm.org/D25674 _

[PATCH] D25674: [Concepts] Class template associated constraints

2016-10-17 Thread Hubert Tong via cfe-commits
hubert.reinterpretcast created this revision. hubert.reinterpretcast added reviewers: rsmith, faisalv, aaron.ballman. hubert.reinterpretcast added subscribers: nwilson, cfe-commits. This adds associated constraints as a property of class templates. An error is produced if redeclarations are not si