[PATCH] D25659: [clang-tidy] Avoid running aliased checks twice

2016-12-18 Thread Malcolm Parsons via Phabricator via cfe-commits
malcolm.parsons abandoned this revision. malcolm.parsons added a comment. Abandon until we have a plan. https://reviews.llvm.org/D25659 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D25659: [clang-tidy] Avoid running aliased checks twice

2016-11-10 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. In https://reviews.llvm.org/D25659#589386, @malcolm.parsons wrote: > In https://reviews.llvm.org/D25659#588658, @alexfh wrote: > > > I think, silently choosing one of the checks may be confusing and > > counter-intuitive. Should we just warn in case we see the same

[PATCH] D25659: [clang-tidy] Avoid running aliased checks twice

2016-11-08 Thread Malcolm Parsons via cfe-commits
malcolm.parsons added a comment. In https://reviews.llvm.org/D25659#588658, @alexfh wrote: > I think, silently choosing one of the checks may be confusing and > counter-intuitive. Should we just warn in case we see the same check enabled > by multiple aliases? A warning is useful if the check

[PATCH] D25659: [clang-tidy] Avoid running aliased checks twice

2016-11-08 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. In https://reviews.llvm.org/D25659#589081, @malcolm.parsons wrote: > In https://reviews.llvm.org/D25659#588663, @alexfh wrote: > > > In https://reviews.llvm.org/D25659#588658, @alexfh wrote: > > > > > I think, silently choosing one of the checks may be confusing and > > >

[PATCH] D25659: [clang-tidy] Avoid running aliased checks twice

2016-11-08 Thread Malcolm Parsons via cfe-commits
malcolm.parsons added a comment. In https://reviews.llvm.org/D25659#588663, @alexfh wrote: > In https://reviews.llvm.org/D25659#588658, @alexfh wrote: > > > I think, silently choosing one of the checks may be confusing and > > counter-intuitive. Should we just warn in case we see the same check

[PATCH] D25659: [clang-tidy] Avoid running aliased checks twice

2016-11-07 Thread Alexander Kornienko via cfe-commits
alexfh requested changes to this revision. alexfh added a comment. This revision now requires changes to proceed. In https://reviews.llvm.org/D25659#588658, @alexfh wrote: > I think, silently choosing one of the checks may be confusing and > counter-intuitive. Should we just warn in case we see

[PATCH] D25659: [clang-tidy] Avoid running aliased checks twice

2016-11-07 Thread Alexander Kornienko via cfe-commits
alexfh added a comment. I think, silently choosing one of the checks may be confusing and counter-intuitive. Should we just warn in case we see the same check enabled by multiple aliases? https://reviews.llvm.org/D25659 ___ cfe-commits mailing lis

[PATCH] D25659: [clang-tidy] Avoid running aliased checks twice

2016-11-01 Thread Malcolm Parsons via cfe-commits
malcolm.parsons added a comment. In https://reviews.llvm.org/D25659#585234, @aaron.ballman wrote: > In https://reviews.llvm.org/D25659#585154, @malcolm.parsons wrote: > > > In https://reviews.llvm.org/D25659#584986, @aaron.ballman wrote: > > > > > (1) I think that the aliases and the originals sh

[PATCH] D25659: [clang-tidy] Avoid running aliased checks twice

2016-11-01 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. In https://reviews.llvm.org/D25659#585154, @malcolm.parsons wrote: > In https://reviews.llvm.org/D25659#584986, @aaron.ballman wrote: > > > (1) I think that the aliases and the originals should be listed with > > -list-checks, because these are names under which th

[PATCH] D25659: [clang-tidy] Avoid running aliased checks twice

2016-11-01 Thread Malcolm Parsons via cfe-commits
malcolm.parsons added a comment. In https://reviews.llvm.org/D25659#584986, @aaron.ballman wrote: > (1) I think that the aliases and the originals should be listed with > -list-checks, because these are names under which the checks may be run (and > sometimes the name may even imply different s

[PATCH] D25659: [clang-tidy] Avoid running aliased checks twice

2016-11-01 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. I *really* like this idea, thank you for working on this! A few things: (0) I'm uncomfortable with the lack of tests in the patch. I'm not certain of a good way to test this, however. @alexfh, do you have ideas? (1) I think that the aliases and the originals should

[PATCH] D25659: [clang-tidy] Avoid running aliased checks twice

2016-10-31 Thread Malcolm Parsons via cfe-commits
malcolm.parsons added a comment. ping. https://reviews.llvm.org/D25659 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25659: [clang-tidy] Avoid running aliased checks twice

2016-10-16 Thread Malcolm Parsons via cfe-commits
malcolm.parsons created this revision. malcolm.parsons added reviewers: aaron.ballman, klimek, alexfh. malcolm.parsons added a subscriber: cfe-commits. Herald added a subscriber: nemanjai. It is easy to configure clang-tidy with both aliased and original checks enabled. This causes the check to b