[PATCH] D25612: [clang-tidy] Add additional diagnostic to misc-use-after-move

2016-10-14 Thread Martin Böhme via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL284235: [clang-tidy] Add additional diagnostic to misc-use-after-move (authored by mboehme). Changed prior to commit: https://reviews.llvm.org/D25612?vs=74671&id=74673#toc Repository: rL LLVM https:

[PATCH] D25612: [clang-tidy] Add additional diagnostic to misc-use-after-move

2016-10-14 Thread Martin Böhme via cfe-commits
mboehme updated this revision to Diff 74671. mboehme added a comment. - Responses to reviewer comments https://reviews.llvm.org/D25612 Files: clang-tidy/misc/UseAfterMoveCheck.cpp test/clang-tidy/misc-use-after-move.cpp Index: test/clang-tidy/misc-use-after-move.cpp ==

[PATCH] D25612: [clang-tidy] Add additional diagnostic to misc-use-after-move

2016-10-14 Thread Haojian Wu via cfe-commits
hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land. The code looks good. Comment at: clang-tidy/misc/UseAfterMoveCheck.cpp:579 DiagnosticIDs::Note); + } else if(UseLoc < MoveLoc || Use.DeclRef == MoveArg) { +

[PATCH] D25612: [clang-tidy] Add additional diagnostic to misc-use-after-move

2016-10-14 Thread Martin Böhme via cfe-commits
mboehme created this revision. mboehme added a reviewer: hokein. mboehme added a subscriber: cfe-commits. This adds a diagnostic to the misc-use-after-move check that is output when the use happens on a later loop iteration than the move, for example: A a; for (int i = 0; i < 10; ++i) { a