ioeric abandoned this revision.
ioeric added a comment.
Thanks all!
https://reviews.llvm.org/D25597
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
Nice! Thanks
https://reviews.llvm.org/D25597
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kparzysz added a comment.
I committed https://reviews.llvm.org/rL284383 and the Hexagon bot is passing
now. (The patch was reverted, but then it was recommitted.)
https://reviews.llvm.org/D25597
___
cfe-commits mailing list
cfe-commits@lists.llvm.o
kparzysz added a comment.
Printing Path shows
`/../target/hexagon/include`
https://reviews.llvm.org/D25597
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kparzysz added a comment.
In https://reviews.llvm.org/D25597#571532, @kparzysz wrote:
> `FileSystemOpts.WorkingDir: ''`
There is no space between the single quotes.
https://reviews.llvm.org/D25597
___
cfe-commits mailing list
cfe-commits@lists.ll
kparzysz added a comment.
This change
bool FileManager::getStatValue(StringRef Path, FileData &Data, bool isFile,
std::unique_ptr *F) {
// FIXME: FileSystemOpts shouldn't be passed in here, all paths should be
// absolute!
llvm::dbgs() << "FileSystemOp
bruno added a comment.
Looks that somehow the current directory doesn't exit anymore OR it's non empty
but only contains spaces or something like that. Besides the snippet below,
RedirectingFileSystem::lookupPath(llvm::Twine const&) also calls `makeAbsolute`
before `remove_dots`. Can you try to
kparzysz added a comment.
The `..:target:hexagon:include:` is debug code printing all the path
components, separated by :.
https://reviews.llvm.org/D25597
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
kparzysz added a comment.
Right on entry to the asserting function:
(gdb) where
#0 0x752b9870 in (anonymous
namespace)::RedirectingFileSystem::lookupPath(llvm::sys::path::const_iterator,
llvm::sys::path::const_iterator, (anonymous namespace)::Entry*) () from
/w/bld/up/bin/../lib/l
bruno added a comment.
Krzysztof, do you have a backtrace that you can paste here or point me to the
buidbot stderr log? There's no point in looking for relative paths inside the
VFS, it would be nice if we fix the root cause here.
https://reviews.llvm.org/D25597
___
kparzysz added a comment.
dbgs showed that the path components were `.. target hexagon include`.
The paths are constructed in lib/Driver/ToolChains.cpp, many are based on
"getHexagonTargetDir".
https://reviews.llvm.org/D25597
___
cfe-commits mailin
bruno added a comment.
One possible reason: remove_dots is called upon a path with a leading "..",
which then gets appended in front of another path to form the absolute path.
I'm taking a look right now to try to figure out if there's any code path that
might lead to this.
https://reviews.ll
bkramer added a comment.
I think the assertion is correct, there's something fishy with the inputs. The
paths coming in should be absolute, and there should never be a .. at the start
in a absolute path. This only fails on a single buildbot and doesn't reproduce
anywhere else. @bruno any ideas?
ioeric updated this revision to Diff 74631.
ioeric added a comment.
- Separate assertions to get more information.
https://reviews.llvm.org/D25597
Files:
lib/Basic/VirtualFileSystem.cpp
Index: lib/Basic/VirtualFileSystem.cpp
==
ioeric created this revision.
ioeric added a reviewer: bkramer.
ioeric added a subscriber: cfe-commits.
Since `remove_dots` does not delete leading "../" anymore, assertion test need
to be updated.
https://reviews.llvm.org/D25597
Files:
lib/Basic/VirtualFileSystem.cpp
Index: lib/Basic/Virtu
15 matches
Mail list logo
