[PATCH] D25531: [libcxx] [test] Include in string_view::copy test

2016-10-24 Thread Eric Fiselier via cfe-commits
EricWF closed this revision. EricWF added a comment. r285012. https://reviews.llvm.org/D25531 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25531: [libcxx] [test] Include in string_view::copy test

2016-10-12 Thread Billy Robert O'Neal III via cfe-commits
BillyONeal added a comment. No, I don't believe any of us in MSVC++ land have commit access. https://reviews.llvm.org/D25531 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25531: [libcxx] [test] Include in string_view::copy test

2016-10-12 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. @BillyONeal Do you have commit access? https://reviews.llvm.org/D25531 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D25531: [libcxx] [test] Include in string_view::copy test

2016-10-12 Thread Billy Robert O'Neal III via cfe-commits
BillyONeal created this revision. BillyONeal added reviewers: EricWF, mclow.lists. BillyONeal added a subscriber: cfe-commits. The string_view::copy test calls std::min, which is not required to be made available by including . (The MSVC++ STL does not use std::min internally because we need to a