Re: [PATCH] D25387: When optimizing for size, enable loop rerolling by default.

2016-10-11 Thread Chris Matthews via cfe-commits
Hal, I noticed since this commit there is a test-suite failure: http://lab.llvm.org:8080/green/job/perf_darwin_x86_Osflto/64/ SingleSource.Benchmarks.Adobe-C++.loop_unroll appears to be failing. Tailing the output of the program gets: … test 236 failed test 236 failed test 236 failed test 236

[PATCH] D25387: When optimizing for size, enable loop rerolling by default.

2016-10-08 Thread Hal Finkel via cfe-commits
hfinkel closed this revision. hfinkel added a comment. r283685 https://reviews.llvm.org/D25387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25387: When optimizing for size, enable loop rerolling by default.

2016-10-08 Thread James Molloy via cfe-commits
jmolloy accepted this revision. jmolloy added a comment. This revision is now accepted and ready to land. Good idea! LGTM! https://reviews.llvm.org/D25387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D25387: When optimizing for size, enable loop rerolling by default.

2016-10-07 Thread Hal Finkel via cfe-commits
hfinkel created this revision. hfinkel added a reviewer: jmolloy. hfinkel added a subscriber: cfe-commits. Herald added a subscriber: mcrosier. We have a loop-rerolling optimization which can be enabled by using -freroll-loops. While sometimes loops are hand-unrolled for performance reasons, whe