This revision was automatically updated to reflect the committed changes.
Closed by commit rL284111: [clang-move] Better support enclosing class.
(authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D25369?vs=74490&id=74492#toc
Repository:
rL LLVM
https://reviews.llvm.org
hokein updated this revision to Diff 74490.
hokein added a comment.
Rebase to master.
https://reviews.llvm.org/D25369
Files:
clang-move/ClangMove.cpp
test/clang-move/Inputs/multiple_class_test.cpp
test/clang-move/Inputs/multiple_class_test.h
test/clang-move/move-multiple-classes.cpp
In
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lg
https://reviews.llvm.org/D25369
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:27
+AST_MATCHER_P(CXXMethodDecl, ofOutermostEnclosingClass,
+ ast_matchers::internal::Matcher, InnerMatcher) {
ioeric wrote:
> I'm not sure if we really need to limit this to the `o
hokein updated this revision to Diff 73976.
hokein marked 2 inline comments as done.
hokein added a comment.
support moving static member of nested class when moving its enclosing class.
https://reviews.llvm.org/D25369
Files:
clang-move/ClangMove.cpp
test/clang-move/Inputs/multiple_class_te
ioeric added inline comments.
Comment at: clang-move/ClangMove.cpp:27
+AST_MATCHER_P(CXXMethodDecl, ofOutermostEnclosingClass,
+ ast_matchers::internal::Matcher, InnerMatcher) {
I'm not sure if we really need to limit this to the `outer-most` class
hokein created this revision.
hokein added a reviewer: ioeric.
hokein added a subscriber: cfe-commits.
- When moving an outermost enclosing class, all its nested classes should also
be moved together.
- Add a test for not moving nested class.
https://reviews.llvm.org/D25369
Files:
clang-move
