[PATCH] D25305: [OpenCL] Setting constant address space for array initializers

2016-10-31 Thread Alexey Bader via cfe-commits
bader added a comment. Committed at 285557 with updated tests. https://reviews.llvm.org/D25305 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25305: [OpenCL] Setting constant address space for array initializers

2016-10-26 Thread Anastasia Stulova via cfe-commits
Anastasia accepted this revision. Anastasia added a comment. LGTM! Thanks! https://reviews.llvm.org/D25305 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25305: [OpenCL] Setting constant address space for array initializers

2016-10-26 Thread Alexey Sotkin via cfe-commits
AlexeySotkin added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1272 +if (getLangOpts().OpenCL) { + UA = llvm::GlobalValue::UnnamedAddr::None; + AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant); Anastasia wrote: > AlexeySo

[PATCH] D25305: [OpenCL] Setting constant address space for array initializers

2016-10-26 Thread Alexey Sotkin via cfe-commits
AlexeySotkin updated this revision to Diff 75893. AlexeySotkin added a comment. Setting UnnamedAddr to Global https://reviews.llvm.org/D25305 Files: lib/CodeGen/CGDecl.cpp test/CodeGenOpenCL/private-array-initialization.cl Index: test/CodeGenOpenCL/private-array-initialization.cl

[PATCH] D25305: [OpenCL] Setting constant address space for array initializers

2016-10-25 Thread Anastasia Stulova via cfe-commits
Anastasia added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1272 +if (getLangOpts().OpenCL) { + UA = llvm::GlobalValue::UnnamedAddr::None; + AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant); AlexeySotkin wrote: > bader wr

[PATCH] D25305: [OpenCL] Setting constant address space for array initializers

2016-10-25 Thread Alexey Sotkin via cfe-commits
AlexeySotkin added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1272 +if (getLangOpts().OpenCL) { + UA = llvm::GlobalValue::UnnamedAddr::None; + AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant); bader wrote: > Anastasia wr

[PATCH] D25305: [OpenCL] Setting constant address space for array initializers

2016-10-25 Thread Alexey Bader via cfe-commits
bader added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1272 +if (getLangOpts().OpenCL) { + UA = llvm::GlobalValue::UnnamedAddr::None; + AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant); Anastasia wrote: > bader wrote: >

[PATCH] D25305: [OpenCL] Setting constant address space for array initializers

2016-10-24 Thread Anastasia Stulova via cfe-commits
Anastasia added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1272 +if (getLangOpts().OpenCL) { + UA = llvm::GlobalValue::UnnamedAddr::None; + AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant); bader wrote: > AlexeySotkin wr

[PATCH] D25305: [OpenCL] Setting constant address space for array initializers

2016-10-24 Thread Alexey Sotkin via cfe-commits
AlexeySotkin added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1272 +if (getLangOpts().OpenCL) { + UA = llvm::GlobalValue::UnnamedAddr::None; + AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant); Anastasia wrote: > Why this

[PATCH] D25305: [OpenCL] Setting constant address space for array initializers

2016-10-24 Thread Alexey Bader via cfe-commits
bader added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1272 +if (getLangOpts().OpenCL) { + UA = llvm::GlobalValue::UnnamedAddr::None; + AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant); AlexeySotkin wrote: > Anastasia wr

[PATCH] D25305: [OpenCL] Setting constant address space for array initializers

2016-10-19 Thread Anastasia Stulova via cfe-commits
Anastasia added inline comments. Comment at: lib/CodeGen/CGDecl.cpp:1272 +if (getLangOpts().OpenCL) { + UA = llvm::GlobalValue::UnnamedAddr::None; + AS = CGM.getContext().getTargetAddressSpace(LangAS::opencl_constant); Why this change? https://rev

[PATCH] D25305: [OpenCL] Setting constant address space for array initializers

2016-10-19 Thread Alexey Bader via cfe-commits
bader accepted this revision. bader added a comment. LGTM https://reviews.llvm.org/D25305 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25305: [OpenCL] Setting constant address space for array initializers

2016-10-14 Thread Yaxun Liu via cfe-commits
yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks! https://reviews.llvm.org/D25305 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[PATCH] D25305: [OpenCL] Setting constant address space for array initializers

2016-10-14 Thread Alexey Sotkin via cfe-commits
AlexeySotkin added a comment. Now there should be both :) https://reviews.llvm.org/D25305 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25305: [OpenCL] Setting constant address space for array initializers

2016-10-14 Thread Alexey Sotkin via cfe-commits
AlexeySotkin updated this revision to Diff 74693. AlexeySotkin added a comment. Squashing commits https://reviews.llvm.org/D25305 Files: lib/CodeGen/CGDecl.cpp test/CodeGenOpenCL/private-array-initialization.cl Index: test/CodeGenOpenCL/private-array-initialization.cl

[PATCH] D25305: [OpenCL] Setting constant address space for array initializers

2016-10-14 Thread Yaxun Liu via cfe-commits
yaxunl added a comment. The test looks OK. However, the patch only contains the test now. https://reviews.llvm.org/D25305 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25305: [OpenCL] Setting constant address space for array initializers

2016-10-13 Thread Alexey Sotkin via cfe-commits
AlexeySotkin removed rL LLVM as the repository for this revision. AlexeySotkin updated this revision to Diff 74482. AlexeySotkin added a comment. Adding test checking address space of array initializer https://reviews.llvm.org/D25305 Files: test/CodeGenOpenCL/private-array-initialization.cl

[PATCH] D25305: [OpenCL] Setting constant address space for array initializers

2016-10-06 Thread Yaxun Liu via cfe-commits
yaxunl added a comment. Please add a test. Thanks. Repository: rL LLVM https://reviews.llvm.org/D25305 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits