This revision was automatically updated to reflect the committed changes.
Closed by commit rL298601: [libcxx] Improve code generation for
vector::clear(). (authored by brucem).
Changed prior to commit:
https://reviews.llvm.org/D25241?vs=73790&id=92796#toc
Repository:
rL LLVM
https://reviews
EricWF accepted this revision.
EricWF added a comment.
Still LGTM
Comment at:
test/std/containers/sequences/vector/vector.modifiers/clear.pass.cpp:18
+#include "min_allocator.h"
+
+int main()
LIBCPP_ASSERT requires including test_macros.h
https://reviews.llv
brucem added a comment.
This was accepted long ago, and then I got sidetracked for a while. Is this
still okay to land?
https://reviews.llvm.org/D25241
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/li
mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
LGTM
https://reviews.llvm.org/D25241
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
brucem marked 2 inline comments as done.
brucem added a comment.
These have been addressed, so this should be good for further review.
https://reviews.llvm.org/D25241
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
brucem updated this revision to Diff 73790.
brucem added a comment.
Address comments from mclow.
https://reviews.llvm.org/D25241
Files:
include/vector
test/std/containers/sequences/vector/vector.modifiers/clear.pass.cpp
Index: test/std/containers/sequences/vector/vector.modifiers/clear.pa
mclow.lists added a comment.
I had no idea that we had no tests for `vector::clear`. Oosps.
This looks good to me, but I want to play with the codegen for a bit before
approving it.
Also, you should add `cfe-commits` to the subscribers.
thanks for doing this!
> clear.pass.cpp:25
> +c.cle
brucem created this revision.
brucem added a subscriber: cfe-commits.
By manipulating a local variable in the loop, when the loop can
be optimized away (due to no non-trivial destructors), this lets
it be fully optimized away and we modify the __end_ separately.
This results in a substantial impr
