This revision was automatically updated to reflect the committed changes.
Closed by commit rL283332: Make DeletedLines local variables in
checkEmptyNamespace. (authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D25162?vs=73641&id=73652#toc
Repository:
rL LLVM
https://rev
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good.
https://reviews.llvm.org/D25162
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
ioeric updated this revision to Diff 73641.
ioeric added a comment.
- Added a test case.
https://reviews.llvm.org/D25162
Files:
lib/Format/Format.cpp
unittests/Format/CleanupTest.cpp
Index: unittests/Format/CleanupTest.cpp
==
djasper added a comment.
I think we should add a test for why this was a problem. IIUC, this is caused
by something like:
#if a
#else
#endif
namespace {
}
Because we actually analyze the whole thing twice.
https://reviews.llvm.org/D25162
__
ioeric created this revision.
ioeric added a reviewer: djasper.
ioeric added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
https://reviews.llvm.org/D25162
Files:
lib/Format/Format.cpp
Index: lib/Format/Format.cpp
