[PATCH] D25078: [coroutines] Diagnose when 'main' is declared as a coroutine.

2016-09-30 Thread Gor Nishanov via cfe-commits
GorNishanov added a comment. LGTM I am happy either way. Fixes for co_return can come later. https://reviews.llvm.org/D25078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25078: [coroutines] Diagnose when 'main' is declared as a coroutine.

2016-09-30 Thread Richard Smith via cfe-commits
rsmith added a comment. LGTM, go ahead when Gor is happy. https://reviews.llvm.org/D25078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25078: [Coroutines] Diagnose when 'main' is declared as a coroutine.

2016-09-30 Thread Gor Nishanov via cfe-commits
GorNishanov added inline comments. > DiagnosticSemaKinds.td:8569 >"'%0' cannot be used in a varargs function">; > def ext_coroutine_without_co_await_co_yield : ExtWarn< >"'co_return' used in a function " I am wondering, if we can handle all four cases when function can be a coroutine.