sdardis added a comment.
Thanks.
Repository:
rL LLVM
https://reviews.llvm.org/D25017
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
This revision was automatically updated to reflect the committed changes.
Closed by commit rL284620: [mips][msa] Range check MSA intrinsics with
immediates (authored by sdardis).
Changed prior to commit:
https://reviews.llvm.org/D25017?vs=74499&id=75173#toc
Repository:
rL LLVM
https://revie
vkalintiris added inline comments.
Comment at: lib/Sema/SemaChecking.cpp:1633-1637
+ if (!m)
+return SemaBuiltinConstantArgRange(TheCall, i, l, u);
+
+return SemaBuiltinConstantArgRange(TheCall, i, l, u) ||
+ SemaBuiltinConstantArgMultiple(TheCall, i, m);
-
vkalintiris accepted this revision.
vkalintiris added a comment.
This revision is now accepted and ready to land.
LGTM. See inline comments for a few small changes.
The only issue I've found with test/CodeGen/builtins-mips-msa-error.c is that
GCC checks strictly the signedness of the arguments p
sdardis updated this revision to Diff 74499.
sdardis added a comment.
Update ld / st to respect their range and multiple of 16 constraint.
https://reviews.llvm.org/D25017
Files:
include/clang/Basic/DiagnosticSemaKinds.td
include/clang/Sema/Sema.h
lib/Sema/SemaChecking.cpp
test/CodeGen/b
sdardis created this revision.
sdardis added reviewers: vkalintiris, zoran.jovanovic.
sdardis added a subscriber: cfe-commits.
Herald added a subscriber: sdardis.
This patch teaches clang to range check immediates for MIPS MSA instrincs. This
checking is done strictly in comparison to some existin
