alexfh added a comment.
A few late comments (seems to be relevant to the revision finally committed
after all fixes).
Comment at: clang-tidy/utils/NamespaceAliaser.cpp:35
+return None;
+
+
nit: Too many empty lines.
Comment at: clang-tid
v.g.vassilev added a subscriber: rsmith.
v.g.vassilev added inline comments.
Comment at: clang-tidy/utils/UsingInserter.cpp:58
+ if (AlreadyHasUsingDecl) {
+AddedUsing.emplace(NameInFunction(Function, QualifiedName.str()));
+return None;
bkramer wrote:
>
bkramer added inline comments.
Comment at: clang-tidy/utils/UsingInserter.cpp:58
+ if (AlreadyHasUsingDecl) {
+AddedUsing.emplace(NameInFunction(Function, QualifiedName.str()));
+return None;
v.g.vassilev wrote:
> Using emplace seems to break our modules
v.g.vassilev added inline comments.
Comment at: clang-tidy/utils/UsingInserter.cpp:58
+ if (AlreadyHasUsingDecl) {
+AddedUsing.emplace(NameInFunction(Function, QualifiedName.str()));
+return None;
Using emplace seems to break our modules libstdc++ 4.7 bu
Yeah, "make -j 32" won't compile binaries in clang-tools-extra repo.
"make check-clang-tools" should work though I don't use make. I usually run
`ninja check-clang-tools` command to build all binaries and run all
lint-tests/unittest in clang-extra-tools. There is a remaining build error
in the uni
I figured out make clang-tidy. Compiles now (the typedef was the wrong way
around, and i never noticed because make with the default target continued
to work).
Updated the diff.
On Fri, Oct 14, 2016 at 12:49 PM Julian Bangert wrote:
> Apologies for the breakage. I investigated and it turns out
jbangert removed rL LLVM as the repository for this revision.
jbangert updated this revision to Diff 74737.
Herald added subscribers: mgorny, beanz.
https://reviews.llvm.org/D24997
Files:
clang-tidy/utils/ASTUtils.cpp
clang-tidy/utils/ASTUtils.h
clang-tidy/utils/CMakeLists.txt
clang-tidy/
Apologies for the breakage. I investigated and it turns out my open-source
checkout does not build clang-tidy. I have checked out llvm into ~/llvm,
clang into ~/llvm/tools/clang and clang-extra-tools into
~/llvm/tools/clang/tools/extra.
In ~/llvm-build I run cmake ../llvm && make -j 32 and it doesn
hokein added a comment.
@jbangert, your patch broke the buildbot, and I reverted it in r283985. You
need to add the new source files to the CMakefile. (I saw other compilation
errors after I updated the cmake files, Could you take a look on it? )
Repository:
rL LLVM
https://reviews.llvm.org
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283981: [ClangTidy] Add UsingInserter and NamespaceAliaser
(authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D24997?vs=74311&id=74338#toc
Repository:
rL LLVM
https://reviews.ll
jbangert marked an inline comment as done.
jbangert added a comment.
Thanks for the review!
https://reviews.llvm.org/D24997
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jbangert updated this revision to Diff 74311.
https://reviews.llvm.org/D24997
Files:
clang-tidy/utils/ASTUtils.cpp
clang-tidy/utils/ASTUtils.h
clang-tidy/utils/NamespaceAliaser.cpp
clang-tidy/utils/NamespaceAliaser.h
clang-tidy/utils/UsingInserter.cpp
clang-tidy/utils/UsingInserter.h
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM with one more nit.
Comment at: clang-tidy/utils/ASTUtils.h:25
+
+#endif
missing a trailing comment `// LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_ASTUTILS_H`
jbangert updated this revision to Diff 74187.
jbangert marked 15 inline comments as done.
https://reviews.llvm.org/D24997
Files:
clang-tidy/utils/ASTUtils.cpp
clang-tidy/utils/ASTUtils.h
clang-tidy/utils/NamespaceAliaser.cpp
clang-tidy/utils/NamespaceAliaser.h
clang-tidy/utils/UsingInse
hokein added a comment.
Looks almost fine, a few code-style comments.
> ASTUtils.h:11
> +#ifndef LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_ASTUTILS_H
> +#define LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_ASTUTILS_H
> +#include "clang/AST/AST.h"
A blank line between define guard and include.
> ASTUtils.h:17
>
jbangert created this revision.
jbangert added a reviewer: alexfh.
jbangert added a subscriber: cfe-commits.
jbangert added a project: clang-tools-extra.
This adds helper classes to add using declaractions and namespace aliases to
function bodies. These help making function calls to deeply nested
16 matches
Mail list logo
