mgorny planned changes to this revision.
mgorny added a comment.
I'm going to delay this one a bit. I've already fixed all other distro checks
to use VFS. Now I'd like to update them to use proper numeric parsing.
https://reviews.llvm.org/D24954
__
bruno added inline comments.
Comment at: lib/Driver/ToolChains.cpp:3915
- if (D.getVFS().exists("/etc/SuSE-release"))
-return OpenSUSE;
+ File = llvm::MemoryBuffer::getFile("/etc/SuSE-release");
+ if (File)
mgorny wrote:
> bruno wrote:
> > You should kee
mgorny added inline comments.
Comment at: lib/Driver/ToolChains.cpp:3915
- if (D.getVFS().exists("/etc/SuSE-release"))
-return OpenSUSE;
+ File = llvm::MemoryBuffer::getFile("/etc/SuSE-release");
+ if (File)
bruno wrote:
> You should keep using the VFS t
bruno added a reviewer: bruno.
bruno added inline comments.
Comment at: lib/Driver/ToolChains.cpp:3915
- if (D.getVFS().exists("/etc/SuSE-release"))
-return OpenSUSE;
+ File = llvm::MemoryBuffer::getFile("/etc/SuSE-release");
+ if (File)
You should keep
ismail added a comment.
That looks good to me but I am not a reviewer. Someone else must approve.
https://reviews.llvm.org/D24954
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny retitled this revision from "[ToolChains] Do not assume OpenSUSE for
other SUSE variants" to "[ToolChains] Disable OpenSUSE rules for SLES10".
mgorny updated the summary for this revision.
mgorny updated this revision to Diff 72609.
mgorny added a comment.
Does this one look better for you
