NoQ added inline comments.
> chapuni wrote in CloneDetection.cpp:113
> You should update \param here. See also r283106.
Thanks!! Will do.
Repository:
rL LLVM
https://reviews.llvm.org/D24916
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
NoQ added a comment.
In https://reviews.llvm.org/D24916#561369, @vitalybuka wrote:
> Out of curiosity, how was MSVC crash solved?
It wasn't, unfortunately; phabricator closed this revision by looking at the
commit that was already reverted, with a delay (see
http://lists.llvm.org/pipermail/cf
vitalybuka added a comment.
Out of curiosity, how was MSVC crash solved?
Repository:
rL LLVM
https://reviews.llvm.org/D24916
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
chapuni added inline comments.
> CloneDetection.cpp:113
>/// \param VarDecl The declaration of the variable that is referenced.
>/// \param Range The SourceRange where this variable is referenced.
> + void addVariableOccurence(const VarDecl *VarDecl, const Stmt *Mention) {
You should up
This revision was automatically updated to reflect the committed changes.
Closed by commit rL283094: [analyzer] Improve CloneChecker diagnostics
(authored by dergachev).
Changed prior to commit:
https://reviews.llvm.org/D24916?vs=72991&id=73408#toc
Repository:
rL LLVM
https://reviews.llvm.o
vitalybuka added a comment.
reverted with r283182 as it depends on r283092
https://reviews.llvm.org/D24916
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka added a comment.
reverted with r283182
https://reviews.llvm.org/D24916
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zaks.anna accepted this revision.
zaks.anna added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D24916
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
zaks.anna added inline comments.
Comment at: test/Analysis/copypaste/suspicious-clones.cpp:61
@@ -60,3 +60,3 @@
b /= a + b;
- c -= b * a; // expected-warning{{suspicious code clone detected; did you
mean to use 'a'?}}
+ c -= b * a; // expected-warning{{Suspicious code clone
zaks.anna added inline comments.
Comment at: test/Analysis/copypaste/macros.cpp:8
@@ -7,3 +7,3 @@
-int foo(int a) { // expected-warning{{Detected code clone.}}
+int foo(int a) { // expected-warning{{Clones of this code were detected}}
a = a + 1;
- Duplicate c
zaks.anna added inline comments.
Comment at: test/Analysis/copypaste/suspicious-clones.cpp:61
@@ -60,3 +60,3 @@
b /= a + b;
- c -= b * a; // expected-warning{{suspicious code clone detected; did you
mean to use 'a'?}}
+ c -= b * a; // expected-warning{{Suspicious code clone
zaks.anna added inline comments.
Comment at: test/Analysis/copypaste/functions.cpp:7
@@ -6,3 +6,3 @@
-int max(int a, int b) { // expected-warning{{Detected code clone.}}
+int max(int a, int b) { // expected-warning{{Clone of this code was detected}}
log();
"w
v.g.vassilev added inline comments.
Comment at: lib/StaticAnalyzer/Checkers/CloneChecker.cpp:102
@@ -95,5 +101,3 @@
// as a note.
-DiagEngine.Report(Group.Sequences.front().getStartLoc(), WarnID);
-for (unsigned i = 1; i < Group.Sequences.size(); ++i) {
- DiagEng
NoQ updated this revision to Diff 72521.
NoQ added a comment.
Addressed inline comments on the original review
https://reviews.llvm.org/D24278. Rebased on top of the updated
https://reviews.llvm.org/D24278. Changed warning messages completely according
to Anna's comments in https://reviews.llvm
NoQ created this revision.
NoQ added reviewers: zaks.anna, dcoughlin, v.g.vassilev, teemperor.
NoQ added a subscriber: cfe-commits.
This patch applies the bug reporting technique that is being introduced in
D24278 to CloneChecker. Extra notes highlight cloned code sections.
Examples of HTML repo
15 matches
Mail list logo
