SjoerdMeijer abandoned this revision.
SjoerdMeijer added a comment.
Ok, thanks for the feedback and looking into this. I will abandon this change.
To still answer your question, there is nothing more to it than emitting an
AArch64 build attribute symbol (for library selection). This done based o
echristo added a comment.
Yes, none of this should be added or expanded in TargetOptions.
Thanks!
-eric
https://reviews.llvm.org/D24909
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
hfinkel added a comment.
In https://reviews.llvm.org/D24909#559110, @SjoerdMeijer wrote:
> Hi Hal,
> Thanks for reviewing and you're right: this should work. We actually have
> actually some downstream (aarch64) build attribute selection code that would
> work better with this change. Are you
SjoerdMeijer added a comment.
Hi Hal,
Thanks for reviewing and you're right: this should work. We actually have
actually some downstream (aarch64) build attribute selection code that would
work better with this change. Are you okay with committing this change?
Cheers,
Sjoerd.
https://reviews.
hfinkel added a comment.
I'm fine with setting these for consistency, but I don't understand why our
failure to do this would cause problems. If you look in lib/CodeGen/CGCall.cpp
and you'll see:
if (!CodeGenOpts.FPDenormalMode.empty())
FuncAttrs.addAttribute("denormal-fp-math",
SjoerdMeijer added a comment.
Ping
https://reviews.llvm.org/D24909
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
SjoerdMeijer created this revision.
SjoerdMeijer added reviewers: rengolin, jmolloy, olista01.
SjoerdMeijer added a subscriber: cfe-commits.
This is a fix for not copying fp denormal and trapping options, and depends on
the nfc cleanups in D24906 and D24907.
https://reviews.llvm.org/D24909
File
