Re: [PATCH] D24879: [libc++] Remove math_win32.h

2016-09-23 Thread Shoaib Meenai via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL282328: [libc++] Remove math_win32.h (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D24879?vs=72330&id=72389#toc Repository: rL LLVM https://reviews.llvm.org/D24879 Files:

Re: [PATCH] D24879: [libc++] Remove math_win32.h

2016-09-23 Thread Shoaib Meenai via cfe-commits
smeenai added a comment. It's worth noting that the entirety of the deleted file was guarded by a `#if ((_VC_CRT_MAJOR_VERSION-0) < 12)` anyway (i.e. it would only be included on Visual Studio 2012 and below), so the code was already dead :) https://reviews.llvm.org/D24879 _

Re: [PATCH] D24879: [libc++] Remove math_win32.h

2016-09-23 Thread Eric Fiselier via cfe-commits
EricWF accepted this revision. EricWF added a comment. This revision is now accepted and ready to land. I'll take your word for it. Thanks for the patch. https://reviews.llvm.org/D24879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

[PATCH] D24879: [libc++] Remove math_win32.h

2016-09-23 Thread Shoaib Meenai via cfe-commits
smeenai created this revision. smeenai added reviewers: compnerd, EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. Visual Studio 2013 and onward have all the required functions in their CRT headers, and we don't support older versions anymore. https://reviews.llvm.org/D24879 Files: